Skip to content

test(appium): skip Predict withdraw to Money account smoke spec - #39000

Merged
Cal-L merged 1 commit into
mainfrom
test/skip-predict-withdraw-to-money-account
Nov 5, 2026
Merged

Cal-L merged 1 commit into
mainfrom
test/skip-predict-withdraw-to-money-account

Conversation

@OGPoyraz

@OGPoyraz OGPoyraz commented Nov 5, 2026 •

Copy link
Copy Markdown
Member

Description

tests/smoke-appium/confirmations/pay/predict-withdraw-to-money-account.spec.ts has failed on every scheduled main iOS Appium confirmations smoke run since 2026-11-04 ~16:00 UTC (last pass: 02d9f392158, first fail: 348f68fd49c). It also fails unrelated PRs whenever iOS E2E is selected (e.g. #38422).

After selecting Money account as the pay-with option, the transaction fee row never renders:

Error: element ("~bridge-fee-row") still not displayed
  at predict-withdraw-to-money-account.spec.ts:107

The only dependency change in that window is the core bump in #38688 (@metamask/transaction-controller 72.3.0 → 73.0.0, @metamask/transaction-pay-controller ^30.3.1 → ^30.3.3, @metamask/core-backend ^12 → ^13). transaction-pay-controller 30.3.2 includes "Use shared recipient resolution for Relay and Server quotes" (MetaMask/core#10887), which is the likely cause. This is not yet confirmed.

This PR skips the test on all platforms so CI is unblocked while the fix is investigated. Android was already skipped inside the test, so that inner platform skip is removed. The test should be re-enabled once the root cause is fixed.

Failing runs:

Changelog

CHANGELOG entry: null

Related issues

Refs: #38688

Manual testing steps

N/A. Test-only change that skips an E2E spec.

Screenshots/Recordings

N/A. Failure recordings are in the appium-smoke-videos-appium-confirmations-ios-smoke-1 artifact of the runs linked above.

Before

N/A

After

N/A

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • N/A, test-only change
  • I've tested with a power user scenario
    • N/A, test-only change
  • I've instrumented key operations with Sentry traces for production performance metrics
    • N/A, test-only change

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Test-only change that skips a flaky E2E spec; no production code paths are modified.

Overview
Unblocks CI by skipping the entire Appium smoke case withdraws Predict balance directly to Money account on all platforms, replacing the previous Android-only runtime skip.

The skip comment documents a regression since the core bump in #38686: on iOS, after choosing Money account as pay-with, the fee UI (bridge-fee-row) never appears and the spec times out at verifyTransactionFeeVisible. The test should be re-enabled once that behavior is fixed.

Reviewed by Cursor Bugbot for commit b60bb89. Bugbot is set up for automated code reviews on this repo. Configure here.

@OGPoyraz OGPoyraz added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Nov 5, 2026
@github-actions github-actions Bot added size-S pr-not-ready-for-e2e Skip E2E and block merging. Remove this label once the PR is ready to run the E2E tests. labels Nov 5, 2026
@metamask-ci metamask-ci Bot added the team-confirmations Push issues to confirmations team label Nov 5, 2026
@OGPoyraz
OGPoyraz marked this pull request as ready for review November 5, 2026 13:56
@OGPoyraz OGPoyraz removed the pr-not-ready-for-e2e Skip E2E and block merging. Remove this label once the PR is ready to run the E2E tests. label Nov 5, 2026
@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Smart E2E Test Selection

Selected E2E tags

SmokeConfirmations
SmokePredictions
SmokeMoney

AI Confidence: 95

E2E reasoning

Expand to read

The only changed file is a smoke-appium spec in tests/smoke-appium/confirmations/pay/. The change converts an appiumTest() call to appiumTest.skip() — skipping the entire 'withdraws Predict balance directly to Money account' test on all platforms (previously only Android was skipped inline). No app code is modified. The hard rule seed floor requires SmokeConfirmations (from the spec's location in confirmations/). SmokePredictions is added because the test covers a Predictions withdrawal flow, and SmokeMoney is added because the destination is a Money account — both flows are affected by the skip. Risk is low since this is a pure test-skip change with no functional app code impact.

View run

@sonarqubecloud

sonarqubecloud Bot commented Nov 5, 2026

Copy link
Copy Markdown

@jpuri
jpuri added this pull request to the merge queue Nov 5, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 5, 2026
@wenfix
wenfix added this pull request to the merge queue Nov 5, 2026
@Cal-L
Cal-L removed this pull request from the merge queue due to a manual request Nov 5, 2026
@Cal-L
Cal-L merged commit da2ed9e into main Nov 5, 2026
228 of 246 checks passed
@Cal-L
Cal-L deleted the test/skip-predict-withdraw-to-money-account branch November 5, 2026 19:28
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 5, 2026
@metamask-ci metamask-ci Bot added the release-8.20.0 Issue or pull request that will be included in release 8.20.0 label Nov 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-8.20.0 Issue or pull request that will be included in release 8.20.0 size-S team-confirmations Push issues to confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants