Repository navigation
cp-8.20.0 fix: Revert TransactionController version back to 72.3 - #39024
Conversation
PR template — items to address before "Ready for review"Warnings — informational, address before merging:
See docs/readme/ready-for-review.md for the full Definition of Ready for Review. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
TransactionController version back to 72.3
Smart E2E Test SelectionSelected E2E tags: ALL AI Confidence: 100 E2E reasoningExpand to readThis PR downgrades @metamask/transaction-controller from 73.0.0 to 72.3.0, with a cascading downgrade of @metamask/core-backend from 13.0.0 to 12.3.0. The TransactionController is a critical core component that underpins virtually every on-chain operation in the app:
The downgrade removes @metamask/sentinel-api-service dependency (present in v73 but not v72.3.0), indicating a significant behavioral difference between versions. This is a revert/downgrade scenario, which carries regression risk for any flows that may have been adapted to v73 APIs. The hard rule seed (controller-version-update) already mandated ALL tags. Given the TransactionController's central role in all on-chain flows, running all smoke suites is the appropriate conservative approach to validate no regressions were introduced by this downgrade. |
|
TransactionController version back to 72.3TransactionController version back to 72.3



Description
Reverts
@metamask/transaction-controllerfrom73.0.0back to72.3.0(theresolutionspin inpackage.jsonand the matchingyarn.lockentries).Reason
transaction-controller73 (pinned in #38688) routes every transaction simulation through theSentinelApiService:simulateTransactionsmessenger action instead of callingfetchitself. Mobile does not construct theTransactionController;@metamask/walletdoes, and its messenger setup only delegates the actions thattransaction-controller72 needed. BecauseSentinelApiService:simulateTransactionsis not delegated, everyTransactionControllersimulation throws on 73. Batch gas estimation has noeth_estimateGasfallback, so flows such as MM Pay quotes (e.g. Predict withdraw to Money account) fail withCannot estimate transaction batch total gas as simulation failed.Solution
Go back to the last known good version, 72.3.0, to unblock main. A forward fix that keeps 73 is tracked in #38978 (delegating the Sentinel action to the
TransactionControllermessenger); the bump can be re-applied once that lands.Lockfile side effects of the revert:
@metamask/core-backendresolves back to^12.3.0(from^13.0.0) as a transitive dependency oftransaction-controller, and@metamask/sentinel-api-serviceis no longer pulled in by it.Changelog
CHANGELOG entry: null
Related issues
Fixes: Regression from #38688 where
TransactionControllersimulations (and MM Pay batch gas estimation) fail on mainRefs: #38978
Manual testing steps
Screenshots/Recordings
N/A: dependency version revert only, no UI changes.
Before
N/A
After
N/A
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist
Note
Medium Risk
Touches core transaction simulation and gas estimation paths, but the change is a targeted revert to a previously working version rather than new logic.
Overview
Reverts the
@metamask/transaction-controllerYarn resolution from 73.0.0 to 72.3.0 and updatesyarn.lockaccordingly. There are no application code changes.Version 73 routes transaction simulation through a
SentinelApiService:simulateTransactionsmessenger action that Mobile’s@metamask/walletsetup does not delegate, which broke simulation and batch gas estimation (including MM Pay quote flows). Rolling back restores the prior behavior where simulation does not depend on that action.Lockfile fallout from the downgrade:
transaction-controlleragain pulls@metamask/core-backend@^12.3.0instead of ^13.0.0, and no longer lists@metamask/sentinel-api-serviceas a dependency of that package.Reviewed by Cursor Bugbot for commit c4d0118. Bugbot is set up for automated code reviews on this repo. Configure here.