Skip to content

cp-8.20.0 fix: Revert TransactionController version back to 72.3 - #39024

Merged
OGPoyraz merged 2 commits into
mainfrom
revert/tc-72.3.0
Nov 6, 2026
Merged

OGPoyraz merged 2 commits into
mainfrom
revert/tc-72.3.0

Conversation

@OGPoyraz

@OGPoyraz OGPoyraz commented Nov 5, 2026 •

Copy link
Copy Markdown
Member

Description

Reverts @metamask/transaction-controller from 73.0.0 back to 72.3.0 (the resolutions pin in package.json and the matching yarn.lock entries).

Reason

transaction-controller 73 (pinned in #38688) routes every transaction simulation through the SentinelApiService:simulateTransactions messenger action instead of calling fetch itself. Mobile does not construct the TransactionController; @metamask/wallet does, and its messenger setup only delegates the actions that transaction-controller 72 needed. Because SentinelApiService:simulateTransactions is not delegated, every TransactionController simulation throws on 73. Batch gas estimation has no eth_estimateGas fallback, so flows such as MM Pay quotes (e.g. Predict withdraw to Money account) fail with Cannot estimate transaction batch total gas as simulation failed.

Solution

Go back to the last known good version, 72.3.0, to unblock main. A forward fix that keeps 73 is tracked in #38978 (delegating the Sentinel action to the TransactionController messenger); the bump can be re-applied once that lands.

Lockfile side effects of the revert: @metamask/core-backend resolves back to ^12.3.0 (from ^13.0.0) as a transitive dependency of transaction-controller, and @metamask/sentinel-api-service is no longer pulled in by it.

Changelog

CHANGELOG entry: null

Related issues

Fixes: Regression from #38688 where TransactionController simulations (and MM Pay batch gas estimation) fail on main
Refs: #38978

Manual testing steps

Feature: Transaction simulation and MM Pay quotes

  Scenario: user withdraws Predict balance directly to Money account
    Given the user has a Predict balance and a Money account

    When user opens the Predict withdraw confirmation, enters an amount and selects Money account as the destination
    Then the bridge fee row is shown with a quote
    And the "payment route isn't available" alert is not shown

  Scenario: user confirms a standard transaction
    Given the user is on a regular send or swap confirmation

    When the confirmation loads
    Then transaction simulation / gas estimation succeeds with no errors

Screenshots/Recordings

N/A: dependency version revert only, no UI changes.

Before

N/A

After

N/A

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Touches core transaction simulation and gas estimation paths, but the change is a targeted revert to a previously working version rather than new logic.

Overview
Reverts the @metamask/transaction-controller Yarn resolution from 73.0.0 to 72.3.0 and updates yarn.lock accordingly. There are no application code changes.

Version 73 routes transaction simulation through a SentinelApiService:simulateTransactions messenger action that Mobile’s @metamask/wallet setup does not delegate, which broke simulation and batch gas estimation (including MM Pay quote flows). Rolling back restores the prior behavior where simulation does not depend on that action.

Lockfile fallout from the downgrade: transaction-controller again pulls @metamask/core-backend@^12.3.0 instead of ^13.0.0, and no longer lists @metamask/sentinel-api-service as a dependency of that package.

Reviewed by Cursor Bugbot for commit c4d0118. Bugbot is set up for automated code reviews on this repo. Configure here.

@metamask-ci metamask-ci Bot added the team-confirmations Push issues to confirmations team label Nov 5, 2026
@metamask-ci

metamask-ci Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

PR template — items to address before "Ready for review"

Warnings — informational, address before merging:

  • Pre-merge author checklist has unchecked items (e.g. "I've tested on Android"). Every box must be consciously checked — see docs/readme/ready-for-review.md.

See docs/readme/ready-for-review.md for the full Definition of Ready for Review.

@OGPoyraz OGPoyraz changed the title Revert TC version back to 72.3 fix: Revert TC version back to 72.3 Nov 5, 2026
@socket-security

socket-security Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatednpm/​@​metamask/​transaction-controller@​73.0.0 ⏵ 72.3.09810081 +1100100

View full report

@OGPoyraz OGPoyraz changed the title fix: Revert TC version back to 72.3 fix: Revert TransactionController version back to 72.3 Nov 5, 2026
@github-actions

github-actions Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Smart E2E Test Selection

Selected E2E tags: ALL

AI Confidence: 100

E2E reasoning

Expand to read

This PR downgrades @metamask/transaction-controller from 73.0.0 to 72.3.0, with a cascading downgrade of @metamask/core-backend from 13.0.0 to 12.3.0. The TransactionController is a critical core component that underpins virtually every on-chain operation in the app:

  1. Transaction sending (ETH, ERC-20, tokens) — directly affects SmokeConfirmations
  2. Swap and bridge flows — transactions are part of swap/bridge execution (SmokeSwap)
  3. Staking/lending flows — on-chain operations (SmokeStake)
  4. Wallet platform — transaction history display (SmokeWalletPlatform)
  5. Profile sync — core-backend downgrade changes @metamask/profile-sync-controller from ^36.0.0 to ^34.0.3, affecting account sync (SmokeAccounts)
  6. Perps/Predictions — on-chain deposit transactions (SmokePerps, SmokePredictions)
  7. Money/ramps — fiat on/off-ramp flows that execute transactions (SmokeMoney)

The downgrade removes @metamask/sentinel-api-service dependency (present in v73 but not v72.3.0), indicating a significant behavioral difference between versions. This is a revert/downgrade scenario, which carries regression risk for any flows that may have been adapted to v73 APIs.

The hard rule seed (controller-version-update) already mandated ALL tags. Given the TransactionController's central role in all on-chain flows, running all smoke suites is the appropriate conservative approach to validate no regressions were introduced by this downgrade.

View run

@OGPoyraz
OGPoyraz marked this pull request as ready for review November 5, 2026 17:28
@sonarqubecloud

sonarqubecloud Bot commented Nov 6, 2026

Copy link
Copy Markdown

@OGPoyraz
OGPoyraz added this pull request to the merge queue Nov 6, 2026
Merged via the queue into main with commit 619e575 Nov 6, 2026
116 checks passed
@OGPoyraz
OGPoyraz deleted the revert/tc-72.3.0 branch November 6, 2026 09:15
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 6, 2026
@metamask-ci metamask-ci Bot added the release-8.21.0 Issue or pull request that will be included in release 8.21.0 label Nov 6, 2026
@OGPoyraz OGPoyraz changed the title fix: Revert TransactionController version back to 72.3 cp-8.20.0 fix: Revert TransactionController version back to 72.3 Nov 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-8.21.0 Issue or pull request that will be included in release 8.21.0 size-XS team-confirmations Push issues to confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants