Repository navigation
feat(kyc): delete identity data from security settings cp-8.21.0 - #39037
Conversation
Put encrypted identity deletion on the existing Security settings page so customers do not need a separate screen. Co-authored-by: Cursor <cursoragent@cursor.com>
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Smart E2E Test SelectionSelected E2E tagsSmokeSeedlessOnboarding AI Confidence: 88 E2E reasoningExpand to readPR adds a new DeleteIdentityData section to Security Settings (below DeleteWalletData), a new test ID constant, and additive locale keys. The section is gated by neobank market and KYC state and returns null when ineligible. The only plausible effect on smoke specs is a layout shift in Security Settings, which could touch SRP reveal/export and delete wallet/reset flows. Keeping the seed tags SmokeAccounts and SmokeSeedlessOnboarding covers those. |
@metamask/kyc-controller 0.16.0 makes deleteEncryptedStorage take
{ aal2Token }. Confirming deletion now runs email OTP through
useMfa().verifyOrEnroll and passes the access token. Cancelling
that flow leaves the data in place.
Co-authored-by: george.weiler <george.weiler@consensys.net>
Signed-off-by: Sébastien Van Eyck <sebastien.vaneyck@consensys.net>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit cb07387. Configure here.
Signed-off-by: Sébastien Van Eyck <sebastien.vaneyck@consensys.net>
|
|
hey @georgeweiler! is there any chance we could get a follow up with a few small copy updates for the delete identity data section (all under
thank you! |




Description
Customers who have started identity verification can delete the encrypted identity data MetaMask holds from Security settings, without a separate screen.
The section appears only when the money-account flag is on and a KYC session exists. Confirming calls
KycController.deleteEncryptedStorage(). That requires@metamask/kyc-controller0.15.0 and theKycService:createDeletionandKycService:completeDeletionmessenger actions. Cancelling the confirmation leaves the data in place.Performance checks do not apply: this is a static settings section with no lists, polling, or animation. It has not been exercised on a device yet.
Changelog
CHANGELOG entry: Added a Security settings control to delete encrypted identity verification data.
Related issues
Fixes:
Refs: #38381
Manual testing steps
Screenshots/Recordings
Before
N/A
After
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist
Description
Customers who have started identity verification can delete the encrypted identity data MetaMask holds from Security settings, without a separate screen.
The section appears only when the money-account flag is on and a KYC session exists. Confirming asks for an email one-time code, then calls
KycController.deleteEncryptedStorage({ aal2Token })with that verification token. That requires@metamask/kyc-controller0.16.0 and theKycService:createDeletionandKycService:completeDeletionmessenger actions. Cancelling the confirmation, or backing out of the email check, leaves the data in place.Performance checks do not apply: this is a static settings section with no lists, polling, or animation. It has not been exercised on a device yet.
Changelog
CHANGELOG entry: Added a Security settings control to delete encrypted identity verification data.
Related issues
Fixes:
Refs: #38381
Manual testing steps
Screenshots/Recordings
Before
N/A
After
N/A
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist
Note
Medium Risk
Introduces user-triggered deletion of encrypted KYC data with MFA gating; mistakes could affect identity verification state, but scope is limited to customers with an active session and the feature flag.
Reviewed by Cursor Bugbot for commit 23be80c. Bugbot is set up for automated code reviews on this repo. Configure here.