Skip to content

test(vba): add the Add money bank-account gate matrix - #39261

Closed
amitabh94 wants to merge 2 commits into
mainfrom
cursor/vba-add-money-gate-matrix-49f1
Closed

amitabh94 wants to merge 2 commits into
mainfrom
cursor/vba-add-money-gate-matrix-49f1

Conversation

@amitabh94

@amitabh94 amitabh94 commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Description

Test-only. Adds screen tests for the Bank account row on the Add money screen, the main way into bank account signup.

BRL and USD launch separately, each behind its own flag (money-movement-neobank-brl and money-movement-neobank-usd). An older general flag, money-movement-neobank, also exists. If the row reads the wrong flag, turning on one currency could show the other early or hide it after launch. Nothing checked this before.

  • Twelve cases cover every on/off combination of the two currency flags for a new user in Brazil, the US, and Portugal. The row is enabled, hidden, or "Coming soon".
  • When the row is enabled, tapping it opens the vendor terms with the right arrival time: "Arrives in seconds" for Pix (BRL), "Arrives in 2 - 3 business days" for USD.
  • The old general flag does not control signup. BRL on with the old flag off keeps the row enabled. Only the old flag on keeps it "Coming soon".
  • While location has not resolved and a currency flag is open, the row stays hidden.

CI fails if a change breaks this gating.

Supporting changes: markets and legacyFlagEnabled options in tests/component-view/presets/vba.ts, passed through by the renderer in tests/component-view/renderers/vba.tsx.

Independent of #39262 and #39260. Merge in any order.

Test layer placement

Component-view. The row state and vendor-terms copy run through real Redux and the real flag selectors. Only Engine is mocked.

Changelog

CHANGELOG entry: null

Related issues

Refs: N/A (test coverage for the per-currency bank-account gate)

Manual testing steps

N/A. Test-only change.

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Not applicable: test-only change
  • I've tested with a power user scenario
    • Not applicable: test-only change
  • I've instrumented key operations with Sentry traces for production performance metrics
    • Not applicable: test-only change

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Test and fixture changes only; no production app logic modified.

Reviewed by Cursor Bugbot for commit 5d27bf5. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions github-actions Bot added the size-M label Nov 9, 2026
@metamask-ci metamask-ci Bot added the team-money-movement issues related to Money Movement features label Nov 9, 2026
@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Smart E2E Test Selection

Selected E2E tags: No E2E tests selected

AI Confidence: 93

E2E reasoning

Expand to read

All three changed files are Jest component-view test files or helpers: the VBA preset, the VBA renderer, and the MoneyAddMoneySheet view test. The preset change adds optional market and legacy-flag options. The renderer change only reworks a type definition. No production app code changed, and Detox and Appium smoke specs don't use these Jest helpers. My grep to confirm that errored out, so the absence of smoke imports is an inference. No E2E tags are needed.

View run

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.83%. Comparing base (cea87ce) to head (5e2d682).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #39261   +/-   ##
=======================================
  Coverage   87.83%   87.83%           
=======================================
  Files        8127     8127           
  Lines      237657   237657           
  Branches    60392    60392           
=======================================
+ Hits       208735   208740    +5     
+ Misses      16387    16384    -3     
+ Partials    12535    12533    -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@amitabh94
amitabh94 marked this pull request as ready for review November 9, 2026 21:56
@amitabh94
amitabh94 requested review from a team as code owners November 9, 2026 21:56
@cursor
cursor Bot force-pushed the cursor/vba-add-money-gate-matrix-49f1 branch from 5e2d682 to e3890ec Compare November 11, 2026 00:20
@cursor
cursor Bot force-pushed the cursor/vba-add-money-gate-matrix-49f1 branch 2 times, most recently from 7338bb1 to 2cffc77 Compare November 11, 2026 01:30
Co-authored-by: Amitabh Aggarwal <amitabh94@users.noreply.github.com>
@cursor
cursor Bot force-pushed the cursor/vba-add-money-gate-matrix-49f1 branch from 2cffc77 to 0443387 Compare November 11, 2026 02:58
@cursor
cursor Bot marked this pull request as draft November 13, 2026 05:55
@sonarqubecloud

Copy link
Copy Markdown

@cursor

cursor Bot commented Nov 14, 2026

Copy link
Copy Markdown
Contributor

Folded into #39262, which now carries these tests.

@amitabh94 amitabh94 closed this Nov 14, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size-M team-money-movement issues related to Money Movement features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants