Skip to content

test: cover VBA KYC retry after a submitted upload - #39659

Closed
amitabh94 wants to merge 4 commits into
mainfrom
cursor/vba-kyc-retry-loop-view-test-9606
Closed

amitabh94 wants to merge 4 commits into
mainfrom
cursor/vba-kyc-retry-loop-view-test-9606

Conversation

@amitabh94

@amitabh94 amitabh94 commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Description

A KYC retry after a proof-of-address upload was reopening SumSub instead of the retry screen. The provider flow stays submitted after the first upload, so that retry was treated as another identity check. Combined with the two-minute resume after an app restart, SumSub kept opening again.

#39497 sends every retry to the retry screen, whatever the provider flow status is. Try again is still the only way back into SumSub.

This adds a component-view test of the full path: submit, then pending, then a retry status. It checks that the retry screen is shown and that SumSub launches once. A second case reopens onboarding on that same retry and checks that SumSub does not launch again. The second case reopens the money entry on that same retry and submitted provider flow. It does not cover the two-minute post-unlock resume timer.

Test layer placement

Component-view. The bug is which screen appears after the KYC session status changes, through the real VBA onboarding navigator and Redux. Engine is the only mock. The funnel helper already has a unit test; this covers the screens that helper does not.

Changelog

CHANGELOG entry: null

Related issues

Refs: #39497

Manual testing steps

N/A. Test-only change.

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Open in Web Open in Cursor 

Akaryatrh and others added 3 commits November 11, 2026 15:39
Signed-off-by: Sébastien Van Eyck <sebastien.vaneyck@consensys.net>
Signed-off-by: Sébastien Van Eyck <sebastien.vaneyck@consensys.net>
A retry after SumSub has already submitted documents must show the retry
screen and must not launch SumSub again.
@metamask-ci metamask-ci Bot added the team-money-movement issues related to Money Movement features label Nov 13, 2026
@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Smart E2E Test Selection

Selected E2E tags: No E2E tests selected

AI Confidence: 96

E2E reasoning

Expand to read

Both changed files are Jest component-view test infrastructure. tests/component-view/mocks.ts gets four extra mocked Engine methods for the ramps controller: fetchSessionDisclaimers, recordSessionDisclaimers, launchProviderFlow and refreshSessionStatus. The other file is a new VbaProofOfAddressRetry.view.test.tsx. Detox and Appium smoke specs don't import either file, and no app code, shipped UI or E2E spec changed. No smoke tags are needed.

View run

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (fix/TRAM-4291@ede2442). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             fix/TRAM-4291   #39659   +/-   ##
================================================
  Coverage                 ?   87.89%           
================================================
  Files                    ?     8190           
  Lines                    ?   240815           
  Branches                 ?    61179           
================================================
  Hits                     ?   211665           
  Misses                   ?    16494           
  Partials                 ?    12656           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Base automatically changed from fix/TRAM-4291 to main November 13, 2026 19:01
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamask-ci

metamask-ci Bot commented Nov 14, 2026

Copy link
Copy Markdown
Contributor

PR template — items to address before "Ready for review"

Warnings — informational, address before merging:

  • Pre-merge author checklist has unchecked items (e.g. "I've tested on Android"). Every box must be consciously checked — see docs/readme/ready-for-review.md.

See docs/readme/ready-for-review.md for the full Definition of Ready for Review.

@sonarqubecloud

Copy link
Copy Markdown

@cursor

cursor Bot commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

Folded into #39262, which now carries these tests.

@amitabh94 amitabh94 closed this Nov 16, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size-M team-money-movement issues related to Money Movement features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants