Skip to content

Bugfix: android sign - #742

Merged
estebanmino merged 3 commits into
developfrom
bugfix/android-sign
Jun 18, 2019
Merged

estebanmino merged 3 commits into
developfrom
bugfix/android-sign

Conversation

@estebanmino

Copy link
Copy Markdown
Contributor

Description

This bug #739 was produced by the same error we had before adding bookmarks, as android devices are slower we were prompting any signature modal with a title = {} making SignatureRequest crash because WebsiteIcon was receiving the title as an empty object {}. So this was happening for all signature requests without title set in state.
To fix this I used the same code implemented to fix the add bookmark bug (https://github.com/MetaMask/MetaMask/pull/651), and move it to one method to be used for these both cases.

good catch @ibrahimtaveras00 !!

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #739

@estebanmino estebanmino added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Jun 14, 2019

@brunobar79 brunobar79 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 !

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, also did a sanity check on iOS as well, and all is good 👍

@estebanmino
estebanmino merged commit b64b990 into develop Jun 18, 2019
@brunobar79
brunobar79 deleted the bugfix/android-sign branch July 22, 2019 18:15
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
* async getmeta for all signatures

* fix nd measuremyself
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-qa Any New Features that needs a full manual QA prior to being added to a release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PersonalSign not working on Android

3 participants