Repository navigation
Bugfix: android sign - #742
Merged
Merged
Conversation
ibrahimtaveras00
approved these changes
Jun 18, 2019
ibrahimtaveras00
left a comment
Contributor
There was a problem hiding this comment.
Looks good, also did a sanity check on iOS as well, and all is good 👍
rickycodes
pushed a commit
that referenced
this pull request
Jan 31, 2022
* async getmeta for all signatures * fix nd measuremyself
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This bug #739 was produced by the same error we had before adding bookmarks, as android devices are slower we were prompting any signature modal with a
title= {} makingSignatureRequestcrash becauseWebsiteIconwas receiving the title as an empty object {}. So this was happening for all signature requests without title set in state.To fix this I used the same code implemented to fix the add bookmark bug (https://github.com/MetaMask/MetaMask/pull/651), and move it to one method to be used for these both cases.
good catch @ibrahimtaveras00 !!
Checklist
Issue
Resolves #739