Skip to content

Fix E2E confirmation flakiness and object not extensible - #7802

Merged
vinistevam merged 9 commits into
e2e-confirmations-to-smokefrom
e2e-confirmations-to-smoke-fix
Nov 14, 2023
Merged

vinistevam merged 9 commits into
e2e-confirmations-to-smokefrom
e2e-confirmations-to-smoke-fix

Conversation

@vinistevam

@vinistevam vinistevam commented Nov 14, 2023 •

Copy link
Copy Markdown
Contributor

Description

Related issues

Fixes: https://github.com/MetaMask/mobile-planning/issues/1363

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@vinistevam
vinistevam requested a review from a team as a code owner November 14, 2023 16:22
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Comment thread bitrise.yml
asdf plugin add yarn
asdf list all yarn
asdf install yarn latest
asdf install yarn 1.22.19

@vinistevam vinistevam Nov 14, 2023 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just to fix the pipeline until yarn fixes the artifacts in their repo. Once it's fixed we can revert back to latest

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vinistevam
vinistevam merged commit 5207ece into e2e-confirmations-to-smoke Nov 14, 2023
@vinistevam
vinistevam deleted the e2e-confirmations-to-smoke-fix branch November 14, 2023 20:29
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant