Skip to content

fix: improve message display for typed sign messages - #9795

Merged
jpuri merged 16 commits into
mainfrom
typed_sign_data_display
Jun 21, 2024
Merged

jpuri merged 16 commits into
mainfrom
typed_sign_data_display

Conversation

@jpuri

@jpuri jpuri commented May 30, 2024 •

Copy link
Copy Markdown
Contributor

Description

Improve message display for typed sign messages.

Related issues

NA

Manual testing steps

  1. Go to test dapp
  2. Submit typed sign
  3. Message should be well formatted

Screenshots/Recordings

Screenshot 2024-05-30 at 6 54 14 PM

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpuri jpuri added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-confirmations Push issues to confirmations team labels May 30, 2024
@jpuri
jpuri force-pushed the typed_sign_data_display branch from facd7f4 to 46d3325 Compare May 30, 2024 13:24
@jpuri
jpuri marked this pull request as ready for review June 5, 2024 08:35
@jpuri
jpuri requested a review from a team as a code owner June 5, 2024 08:35
@jpuri
jpuri requested a review from a team June 5, 2024 08:35
@jpuri
jpuri requested a review from a team as a code owner June 5, 2024 08:35
@jpuri jpuri added the E2E label Jun 5, 2024
Comment thread app/util/string/index.ts Resolved
@jpuri jpuri added Run Smoke E2E and removed E2E labels Jun 5, 2024
@github-actions

github-actions Bot commented Jun 5, 2024 •

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 867d42d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0f393cb9-5bc8-4776-994f-eda3fd4ff1d2

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sleepytanya

sleepytanya commented Jun 5, 2024 •

Copy link
Copy Markdown
Contributor

@jpuri Looks good?

Bitrise build: https://app.bitrise.io/build/b40dbb16-9e38-4d18-94ad-a366f64597a3?tab=artifacts

Android 14, Samsung S24+

signTypedData.mov

vinistevam
vinistevam previously approved these changes Jun 13, 2024
matthewwalsh0
matthewwalsh0 previously approved these changes Jun 13, 2024
Comment thread app/util/string/index.text.ts Resolved
@jpuri
jpuri dismissed stale reviews from matthewwalsh0 and vinistevam via c508b65 June 17, 2024 05:03
vinistevam
vinistevam previously approved these changes Jun 18, 2024
matthewwalsh0
matthewwalsh0 previously approved these changes Jun 18, 2024
Comment thread app/util/string/index.ts Resolved
@jpuri
jpuri dismissed stale reviews from matthewwalsh0 and vinistevam via db669e5 June 21, 2024 10:48
@github-actions

github-actions Bot commented Jun 21, 2024 •

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 6f27dfc
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d501a861-ed27-4682-805b-705f69531ba8

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@jpuri
jpuri requested review from matthewwalsh0 and tommasini June 21, 2024 12:41
@sonarqubecloud

Copy link
Copy Markdown

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 87.50000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 49.26%. Comparing base (b013c71) to head (6f27dfc).
Report is 104 commits behind head on main.

Files Patch % Lines
app/util/string/index.ts 89.09% 3 Missing and 3 partials ⚠️
.../Views/confirmations/components/TypedSign/index.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9795      +/-   ##
==========================================
+ Coverage   47.24%   49.26%   +2.01%     
==========================================
  Files        1370     1422      +52     
  Lines       33304    34408    +1104     
  Branches     3586     3787     +201     
==========================================
+ Hits        15736    16951    +1215     
+ Misses      16607    16410     -197     
- Partials      961     1047      +86     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jpuri
jpuri requested a review from vinistevam June 21, 2024 14:06

@tommasini tommasini left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks! LGTM!

@jpuri
jpuri merged commit c24fc5c into main Jun 21, 2024
@jpuri
jpuri deleted the typed_sign_data_display branch June 21, 2024 17:58
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 21, 2024
@github-actions github-actions Bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jun 21, 2024
@metamaskbot metamaskbot added the release-7.27.0 Issue or pull request that will be included in release 7.27.0 label Jun 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.27.0 Issue or pull request that will be included in release 7.27.0 team-confirmations Push issues to confirmations team

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

7 participants