Repository navigation
fix(auto-changelog): parse combined short PR references like (#A, #B) - #130
Merged
Merged
Conversation
mcmire
approved these changes
Oct 23, 2026
mcmire
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Made a comment about the changelog but it is non-blocking.
Comment on lines
12
to
+19
| - Improve populating changelogs from commits/PRs to prepare for AI-powered release workflows in MetaMask clients ([#127](https://github.com/MetaMask/release-tools/pull/127)) | ||
| - Handle extracting the PR number from a Runway-generated cherry-pick commit subject even when the subject has been hard-wrapped | ||
| - Repair a Markdown link that accidentally splits a word | ||
| - Handle parsing the PR number from a malformed link | ||
| - Don't skip a PR that has a non-empty `CHANGELOG entry:` line even when it also has a `no-changelog` label | ||
| - Use the trailing squash-merge PR reference when a commit subject includes both an original PR and its own PR | ||
| - Parse a combined short PR reference such as `(#79, #91)` in an existing changelog entry as separate PRs ([#130](https://github.com/MetaMask/release-tools/pull/130)) | ||
| - Previously no PR numbers were extracted, so PRs documented this way were regenerated as duplicate entries in later releases |
Contributor
There was a problem hiding this comment.
Nit: Should this be grouped with the list of improvements listed above?
Suggested change
| - Previously no PR numbers were extracted, so PRs documented this way were regenerated as duplicate entries in later releases | |
| - Improve populating changelogs from commits/PRs to prepare for AI-powered release workflows in MetaMask clients ([#127](https://github.com/MetaMask/release-tools/pull/127), [#130](https://github.com/MetaMask/release-tools/pull/130)) | |
| - Handle extracting the PR number from a Runway-generated cherry-pick commit subject even when the subject has been hard-wrapped | |
| - Repair a Markdown link that accidentally splits a word | |
| - Handle parsing the PR number from a malformed link | |
| - Don't skip a PR that has a non-empty `CHANGELOG entry:` line even when it also has a `no-changelog` label | |
| - Use the trailing squash-merge PR reference when a commit subject includes both an original PR and its own PR | |
| - Parse a combined short PR reference such as `(#79, #91)` in an existing changelog entry as separate PRs (previously no PR numbers were extracted, so PRs documented this way were regenerated as duplicate entries in later releases) |
JadeCong
pushed a commit
to CloudEngineHub/metamask-extension
that referenced
this pull request
Oct 29, 2026
…MetaMask#47463) ## **Description** This is the very last step in a chain of PRs to turn on fully-autonomous CHANGELOG generation in Extension. ## **Changelog** CHANGELOG entry: null ## **Related issues** ### Previous PRs in the chain #### release-tools/auto-changelog MetaMask/release-tools#127 MetaMask/release-tools#130 #### github-tools MetaMask/github-tools#300 MetaMask/github-tools#301 MetaMask/github-tools#303 <!--## **Manual testing steps** ## **Screenshots/Recordings** ## **Pre-merge author checklist** ## **Pre-merge reviewer checklist**--> <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Workflow-only change that adds a CI secret env var and removes an action input; no runtime extension code or user-facing behavior changes. > > **Overview** > Turns on the **AI changelog proofreader** for release changelog automation by passing **`AI_ANALYZER_LITELLM_KEY`** into the `update-release-changelog` GitHub Action (same LiteLLM secret pattern as other AI workflows). > > Also **drops the explicit `previous-version-ref: 'null'`** input so previous-version resolution is handled by the updated action rather than being hard-coded in this repo. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit c801241. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
darkwing
pushed a commit
to darkwing/metamask-mobile
that referenced
this pull request
Oct 29, 2026
…MetaMask#38444) ## **Description** This is the very last step in a chain of PRs to turn on fully-autonomous CHANGELOG generation in Mobile. ## **Changelog** CHANGELOG entry: null ## **Related issues** ### Previous PRs in the chain #### release-tools/auto-changelog MetaMask/release-tools#127 MetaMask/release-tools#130 #### github-tools MetaMask/github-tools#300 MetaMask/github-tools#301 MetaMask/github-tools#303 <!--## **Manual testing steps** ## **Screenshots/Recordings** ## **Pre-merge author checklist** ## **Pre-merge reviewer checklist**--> <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Changes how release and OTA hotfix changelogs are produced in CI; misconfiguration could break changelog PRs or tags, though behavior is intended to match the removed script via github-tools v1. > > **Overview** > Mobile release changelog automation no longer runs the local **`run-update-release-changelog-mobile.sh`** wrapper or manual **github-tools** checkout, Node setup, and **`yarn`** steps. **`create-release-pr.yml`** (OTA hotfix path) and **`update-release-changelog.yml`** now call **`MetaMask/github-tools/.github/actions/update-release-changelog@v1`**, which owns branch checkout, version derivation from **`release/X.Y.Z`** / **`release/X.Y.Z-ota`**, and concurrent Runway updates on the release branch. > > This PR also threads **`AI_ANALYZER_LITELLM_KEY`** from **`auto-create-release-pr.yml`** into **`create-release-pr.yml`** as an optional reusable-workflow secret and passes it into both changelog action steps so the new AI changelog proofreader can run during autonomous **`CHANGELOG.md`** generation. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 1abeae5. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: howard <howard@example.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes how auto-changelog reads a combined short PR reference such as
(#79, #91)in an existing changelog entry. These entries are written by the AI-powered release workflows and by hand-merged entries.Previously
extractPrLinksreturned no PR numbers for that form. The long-link form,([#A](url), [#B](url)), was already parsed correctly. As a result, PRs documented as(#A, #B)in an older release section were treated as undocumented. They were regenerated into the next release, producing duplicate entries. We saw this in the Mobile 8.18.0 changelog.- Fixed a bug (#79, #91)now yields PRs79and91, rather than none(#N), and the long-link formsTests cover the combined group, and both fail without the fix.
Validation
Verified end to end on a fork of
MetaMask/metamask-extensionusing the release-changelog workflow:(#81, #82), and a new commit for#82follows it.#82was regenerated into the new release section.#82is skipped as already documented, and the other entries are unchanged.