Skip to content

refactor(create-release-branch): let a mode name its prepare step - #166

Open
GuillaumeRx wants to merge 1 commit into
mainfrom
gr/crb-cs-02-core-seams
Open

GuillaumeRx wants to merge 1 commit into
mainfrom
gr/crb-cs-02-core-seams

Conversation

@GuillaumeRx

@GuillaumeRx GuillaumeRx commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Explanation

A core change for the Changesets mode: the mode names its prepare step.

prepare is now a ModePrepareStep with a title, a result, and a run function. The core shows the title and the result that the mode gives, so the "Updating changelogs" labels move to the legacy mode. Legacy mode uses the step to update the changelogs.

This PR also adds small shared helpers in core:

  • UserFacingError.buildPlainMessage builds the unstyled constructor message from describe.
  • resolveVersionSpecifier and suggestVersionSpecifier in release-rules.ts resolve and propose SemVer bump specifiers.

The legacy output does not change.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

@GuillaumeRx
GuillaumeRx added this pull request to stack #171 November 12, 2026 14:07
@GuillaumeRx
GuillaumeRx force-pushed the gr/crb-cs-02-core-seams branch 2 times, most recently from 3d1a722 to ed08045 Compare November 12, 2026 16:11
@GuillaumeRx GuillaumeRx changed the title refactor(create-release-branch): make prepare optional and add info notices refactor(create-release-branch): let a mode name or leave out its prepare step Nov 12, 2026
@GuillaumeRx
GuillaumeRx force-pushed the gr/crb-cs-02-core-seams branch from ed08045 to eeceeb9 Compare November 13, 2026 10:28
@GuillaumeRx GuillaumeRx changed the title refactor(create-release-branch): let a mode name or leave out its prepare step refactor(create-release-branch): let a mode name its prepare step Nov 13, 2026
The prepare step of a mode is now an object with a title, a result, and a
run function. The core shows the title and the result that the mode
gives, so the "Updating changelogs" labels move to the legacy mode.

Also extract shared helpers in core:
- `UserFacingError.buildPlainMessage` for plain constructor messages.
- `resolveVersionSpecifier` and `suggestVersionSpecifier` in `release-rules.ts`.
@GuillaumeRx
GuillaumeRx force-pushed the gr/crb-cs-02-core-seams branch from eeceeb9 to b97bd6c Compare November 16, 2026 11:20
@GuillaumeRx
GuillaumeRx marked this pull request as ready for review November 16, 2026 12:43
@GuillaumeRx
GuillaumeRx requested a review from a team as a code owner November 16, 2026 12:43
@GuillaumeRx
GuillaumeRx deployed to default-branch November 16, 2026 12:43 — with GitHub Actions Active

This branch was successfully deployed

1 active deployment
default-branch — b97bd6c4 Deployed Nov 16, 2026 by GuillaumeRx via Determine whether this PR is a release PR #234
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant