Skip to content

refactor(perps): compose thorough static review through repository overlays - #183

Merged
abretonc7s merged 11 commits into
mainfrom
feat/perps-review-only-independent
Sep 29, 2026
Merged

abretonc7s merged 11 commits into
mainfrom
feat/perps-review-only-independent

Conversation

@abretonc7s

@abretonc7s abretonc7s commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Make Perps static review a shared execution checklist plus the repository's standard repos/ overlay. Detailed rules live in four references: shared, Mobile, Extension and Core. Each applicable rule needs a cited outcome; missing required evidence prevents approval.

Remove the duplicate generated review-template catalog. Farmslot executes the frozen shared skill and selected overlay as consecutive child checklists. Keep the canonical library revision/digests, explicit invocation, and an authoring guide other teams can adapt.

Validation: 73 tests pass, including generation and standard installation for all three clients. Task-runtime proof registers both child units, refuses incomplete completion and preserves the parent gate. A fresh unsteered static reviewer caught the seeded fee-tie defect, cited the Core rule, and retained missing-evidence gaps. Independent review approved the implementation; provenance points at merged library e06bb8d. README.md is unchanged.

@abretonc7s abretonc7s changed the title feat(perps): distribute standalone review criteria and retained lessons feat(perps): refresh review criteria from retained lessons Sep 28, 2026
@abretonc7s abretonc7s changed the title feat(perps): refresh review criteria from retained lessons refactor(perps): compose thorough static review through repository overlays Sep 28, 2026
@abretonc7s
abretonc7s enabled auto-merge (squash) September 29, 2026 11:15

@NicolasMassart NicolasMassart left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove or rewrite the stale Unreleased changelog entry saying perps-review-pr is a thin mm-harness wrapper and its repository overlay is removed. It contradicts this PR’s implementation and new changelog entry.

@abretonc7s
abretonc7s merged commit aa0d897 into main Sep 29, 2026
28 checks passed
@abretonc7s
abretonc7s deleted the feat/perps-review-only-independent branch September 29, 2026 12:34
@georgewrmarshall georgewrmarshall mentioned this pull request Nov 17, 2026
georgewrmarshall added a commit that referenced this pull request Nov 18, 2026
## Release `@metamask/skills` 0.4.0

This is the release candidate for **0.4.0**, a minor release that brings
in everything merged to `main` since
[v0.3.1](https://github.com/MetaMask/skills/releases/tag/v0.3.1) (66
PRs). See `CHANGELOG.md` for the full list with PR links.

### Highlights

**New domains**
- `observability`: Sentry, Tempo and telemetry cost-control skills
- `performance`: measurement, anti-pattern scanning and React Compiler
triage
- `typescript`: authoring and migration skills
- `platform`: Extension runtime architecture and failure modes

**New skills**
- Mobile planning (`planning`, `planning-spec`, `jira-brief`), now
stable `base` skills for Mobile and Extension
- `analytics`, `feature-flags`, `navigation` and `selector-patterns`,
each with a repo-agnostic base and a Mobile overlay
- A PR review base skill, generated Perps review checklists,
`notifications-category-sync`, a profiling regression proposal skill and
activity mapper guidance
- Recipe planning and cooking skills, pinned to a single mm-harness
version with an install-time version check

**UI development and content**
- A shared, MCP-free `ui-development` baseline for looking up MetaMask
Design System components, with thin Mobile and Extension overlays
- Content guidelines with shared rules plus Mobile and Extension
overlays, which now also apply when existing strings are edited

**Testing**
- `visual-testing` and `mobile-visual-testing` updated for
`@metamask/client-mcp-core` 0.14.0 and `@metamask/device-mcp` 0.8.0
- Component-view flake rules and Appium stability patterns added to
`mobile-testing`

**Installer / CLI**
- Explicit-only skill invocation, preserved repository overlays and
pruning of retired skill names during sync
- Syncs of each shared skill source run one at a time, so concurrent
syncs can't collide during a Git fetch
- Skill descriptions over the 1024-character catalog limit are shortened

### Changelog

The auto-generated `[0.4.0]` section has been rewritten into Added,
Changed and Fixed entries, written for consumers. It replaces the
`Uncategorized` commit titles, removes duplicates and adds the PRs that
were missing (#159, #183, #212 and #213).

### Release steps

1. Approve the pending workflow run so CI runs on this PR, including
`yarn lint:changelog --rc`, the tests and `yarn pack:dry-run`.
2. Get a review from @MetaMask/extension-platform or
@MetaMask/mobile-platform.
3. Squash-merge, keeping github-actions as the commit author. That's
what lets **Publish Release** run.
4. @metamask-npm-publishers approve the `npm-publish` environment. Then
`@metamask/skills@0.4.0` is published to npm, and the `v0.4.0` GitHub
release and tag are created.

---------

Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: George Marshall <george.marshall@consensys.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants