Repository navigation
fix(planning): install planning skills by default, call Jira only when a ticket is already there - #254
Merged
Conversation
…a nag Base installs were skipped while the skills stayed experimental, and planning called jira-brief on every non-revert path. Ship them as stable base skills, and only open Jira when the engineer already brought a ticket.
NicolasMassart
approved these changes
Nov 17, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Mark
planning,planning-spec, andjira-briefstableandbase: true, so a default install includes them.planningwins over a generic plan, brainstorm, design, or spec skill only when the engineer did not name another skill for that job.planningcallsjira-briefonly when the message has a Jira browse URL or the engineer explicitly refers to a Jira ticket. Otherwise it says nothing about Jira. A planning delegation never asks whether a bare token is a ticket.Opt out with
yarn skills --exclude planning/planning,planning/planning-spec,planning/jira-brief --save.Type of Change
Skill Details (if adding a new skill)
Provider Name:
Skill Name:
Brief Description:
Checklist
Testing
yarn audit:skills: 0 errors. Planning description is 1024 characters.yarn lint:changelog: pass.named-skillruns that reportedoverride=yeswhile correctly keeping the named skill (flag semantics, not behavior). Hard rules held in every scenario. Details below.Cross-lab matrix (92 runs)
23 scenarios × 4 models (claude-sonnet-5-5-high, gpt-6.1-sol-medium, gemini-3.1-pro-preview-high, kimi-k3-high) = 92 runs. Each subagent read the installed
mms-planningSKILL.md in the real mobile/extension checkout and reported only the path decision. Cell =path(+spec/stopped/jira/override when relevant).Counts
named-skillon claude/gemini/kimi reportedoverride=yes. However, all threewhylines state the named brainstorming skill ran and mms-planning did not win — behavior is correct; the models inverted the flag's semantics (read "override" as "an override happened" rather than "planning overrode the named skill"). Only GPT answeredoverride=no.Verdict
Safe to merge for base install. Core path decisions are correct across all four labs in every scenario: mechanical work never blocks, security/contract surfaces always stop for agreement, large new product areas get a spec recommendation, Jira engages only when referenced, and no lab let mms-planning override an explicitly named skill. One nit worth a follow-up line in SKILL.md: define the
overridereport field ("override=yes only when mms-planning replaces the named skill") — 3/4 models inverted it despite behaving correctly. Not a blocker.Raw subagent reports (92 runs)
Additional Context
Base means the description is in every session. The body still loads only when the skill is selected. No
AGENTS.mdline.