Repository navigation
chore: add first-pass domain CODEOWNERS - #59
Conversation
| /domains/portfolio/ @MetaMask/portfolio | ||
|
|
||
| # Domains currently present or pending in open PRs. | ||
| /domains/analytics/ @MetaMask/performance-council |
There was a problem hiding this comment.
Should be data council? @gauthierpetetin @NicolasMassart
There was a problem hiding this comment.
- We should also separate Segment/Metametrics from Sentry/Grafana. I added the
analyticsdomain in Add analytics domain: Sentry quota, MCP queries, instrumentation #41 as a catch-all, but the PR covers subjects outside of data council's perview. - We should probably add engineering teams as co-owners so the councils aren't bothered by frequent low-priority requests.
| /domains/analytics/ @MetaMask/performance-council | |
| /domains/analytics/ @MetaMask/data-council @MetaMask/extension-platform @MetaMask/mobile-platform @MetaMask/core-platform | |
| /domains/observability/ @MetaMask/sre @MetaMask/api-platform @MetaMask/extension-platform @MetaMask/mobile-platform @MetaMask/core-platform |
There was a problem hiding this comment.
Done: analytics is now owned by @MetaMask/data-council with the extension/mobile/core platform teams as co-owners (per Major's suggestion).
There was a problem hiding this comment.
Applied: analytics and observability are split, and engineering teams are co-owners on both.
|
|
||
| # Domains currently present or pending in open PRs. | ||
| /domains/analytics/ @MetaMask/performance-council | ||
| /domains/platform/ @MetaMask/extension-platform @MetaMask/core-platform |
There was a problem hiding this comment.
Should we separate domains into "extension" and "mobile" @v-goyal @MajorLift @andrepimenta
There was a problem hiding this comment.
The idea is to use repo overlays for repo-specific overrides, and by default consolidate content that overlaps e.g. react/redux practices, consuming core packages, release workflows, testing etc. -- especially where we'd want to ensure that agent behavior doesn't diverge between clients/repos.
Something like the following would also work, but I can see it tending towards duplication and fragmentation without active curation.
| /domains/platform/ @MetaMask/extension-platform @MetaMask/core-platform | |
| /domains/platform-core/ @MetaMask/extension-platform @MetaMask/mobile-platform @MetaMask/core-platform | |
| /domains/platform-clients/ @MetaMask/extension-platform @MetaMask/mobile-platform @MetaMask/core-platform | |
| /domains/platform-extension/ @MetaMask/extension-platform @MetaMask/core-platform | |
| /domains/platform-mobile/ @MetaMask/mobile-platform @MetaMask/core-platform |
There was a problem hiding this comment.
Keeping a single platform domain for now, per Major's overlay rationale (repo-specific overrides via overlays). Extension/mobile-specific files under platform keep their own owners. Can split later if it fragments.
There was a problem hiding this comment.
Keeping one platform domain for now, with overlays for repo-specific content, to avoid duplication/fragmentation.
| /domains/ui/ @MetaMask/design-system-engineers @MetaMask/design-system | ||
| /domains/coding/ @MetaMask/engineering | ||
| /domains/pr-workflow/ @MetaMask/engineering | ||
| /domains/general/ @MetaMask/engineering |
There was a problem hiding this comment.
Rather than MetaMask/engineering, maybe we should create a @MetaMask/ai-engineering group
There was a problem hiding this comment.
Is metamask engineering like everyone?
If so, why not not adding CO at all?
There was a problem hiding this comment.
@NicolasMassart It's still a useful layer of branch protection, as long as @MetaMask/engineering is smaller than the set of users with write access to this repo.
There was a problem hiding this comment.
@MetaMask/ai-engineering doesn't exist yet. I'll open a follow-up PR to swap it in once the team is created. For now engineering stays as a co-owner on performance/ui; coding, pr-workflow, general now route to the platform teams (matches current main).
|
|
||
| # Legacy/experimental. | ||
| # ADR-58/recipe skills are experimental but owned by Perps during rollout. | ||
| /domains/agentic/ @MetaMask/perps |
There was a problem hiding this comment.
Should include Arthur, @MajorLift, @cryptotavares @AugmentedMode
There was a problem hiding this comment.
Any CODEOWNERS file needs to guard itself as its highest-priority entry. The very last lines should look something like this:
| /domains/agentic/ @MetaMask/perps | |
| /domains/agentic/ @abretonc7s @MajorLift @cryptotavares @AugmentedMode | |
| # The CODEOWNERS file constitutes an agreement amongst organization | |
| # admins and maintainers to restrict approval capabilities to a subset | |
| # of contributors. Modifications to this file result in a modification of | |
| # that agreement and can only be approved by maintainers of the repo. | |
| # Note: As the highest-priority entry, this rule should always be placed | |
| # at the very bottom of the CODEOWNERS file. | |
| /.github/CODEOWNERS @abretonc7s @MajorLift @cryptotavares @AugmentedMode |
There was a problem hiding this comment.
There should also be an entry to guard the @metamask/skills package. Although maybe we can defer this until v1.0 release to make development easier.
| /domains/agentic/ @MetaMask/perps | |
| /domains/agentic/ @MetaMask/perps | |
| # Changes to the `@metamask/skills` npm package require review from repo maintainers. | |
| /tools/ @abretonc7s @MajorLift @cryptotavares @AugmentedMode |
There was a problem hiding this comment.
Added: maintainers (@abretonc7s @MajorLift @cryptotavares @AugmentedMode) now own /.github/CODEOWNERS as the final entry.
There was a problem hiding this comment.
Applied: CODEOWNERS self-guard added as the last line.
There was a problem hiding this comment.
Deferring /tools/ maintainer-only ownership until v1.0 as you suggested; it stays with the platform teams for now.
| /domains/coding/ @MetaMask/engineering | ||
| /domains/pr-workflow/ @MetaMask/engineering | ||
| /domains/general/ @MetaMask/engineering | ||
| /domains/web3-tools/ @MetaMask/developer-relations |
There was a problem hiding this comment.
Not sure about this one, but also don't have a better suggestion
|
|
||
| # Legacy/experimental. | ||
| # ADR-58/recipe skills are experimental but owned by Perps during rollout. | ||
| /domains/agentic/ @MetaMask/perps |
There was a problem hiding this comment.
Any CODEOWNERS file needs to guard itself as its highest-priority entry. The very last lines should look something like this:
| /domains/agentic/ @MetaMask/perps | |
| /domains/agentic/ @abretonc7s @MajorLift @cryptotavares @AugmentedMode | |
| # The CODEOWNERS file constitutes an agreement amongst organization | |
| # admins and maintainers to restrict approval capabilities to a subset | |
| # of contributors. Modifications to this file result in a modification of | |
| # that agreement and can only be approved by maintainers of the repo. | |
| # Note: As the highest-priority entry, this rule should always be placed | |
| # at the very bottom of the CODEOWNERS file. | |
| /.github/CODEOWNERS @abretonc7s @MajorLift @cryptotavares @AugmentedMode |
There was a problem hiding this comment.
- We should add default fallbacks at the top.
- Add more co-owners entries. Note that sole ownership means all contributions to that domain/path are blocked by review from the owners. This is great if strict enforcement is the goal, but not if codeowners are likely to be overwhelmed with low-priority review requests.
| @@ -1,3 +1,31 @@ | |||
| # GitHub code ownership for MetaMask skills. | |||
| # This is a first-pass domain mapping intended for domain-owner review. | |||
There was a problem hiding this comment.
For branch protection and security:
| # This is a first-pass domain mapping intended for domain-owner review. | |
| # By default, executable files in distributable paths require security review. | |
| # This rule is intended as a fallback and can be overridden by subsequent lines. | |
| /domains/ @MetaMask/security-liaisons @MetaMask/policy-reviewers | |
| /domains/**/scripts/ @MetaMask/application-security @MetaMask/security-liaisons @MetaMask/policy-reviewers | |
| /domains/**/adapters/ @MetaMask/application-security @MetaMask/security-liaisons @MetaMask/policy-reviewers | |
| # By default, markdown files in distributable paths do not require codeowner review. | |
| # This rule is intended as a fallback, and can be overridden by subsequent lines. | |
| /domains/**/*.md | |
| /domains/**/*.mdc |
The last rule overrides the ones at the top, so security team members will not be bothered for review on markdown files.
There was a problem hiding this comment.
Leaving this at the top makes it a fallback that will mostly be overridden by domain owners, but depending on how strict we want to make security review, we could move the following lines to the bottom of the file to enforce review on all executable files.
/domains/**/scripts/ @MetaMask/application-security @MetaMask/security-liaisons @MetaMask/policy-reviewers
/domains/**/adapters/ @MetaMask/application-security @MetaMask/security-liaisons @MetaMask/policy-reviewers
There was a problem hiding this comment.
Applied: security fallbacks and the markdown override are at the top, so domain owners override them.
| /domains/platform/ @MetaMask/extension-platform @MetaMask/core-platform | ||
|
|
||
| # Horizontal skills domains. | ||
| /domains/performance/ @MetaMask/performance-council |
There was a problem hiding this comment.
| /domains/performance/ @MetaMask/performance-council | |
| /domains/performance/ @MetaMask/performance-council @MetaMask/engineering |
| # Horizontal skills domains. | ||
| /domains/performance/ @MetaMask/performance-council | ||
| /domains/testing/ @MetaMask/qa | ||
| /domains/ui/ @MetaMask/design-system-engineers @MetaMask/design-system |
There was a problem hiding this comment.
| /domains/ui/ @MetaMask/design-system-engineers @MetaMask/design-system | |
| /domains/ui/ @MetaMask/design-system-engineers @MetaMask/design-system @MetaMask/engineering |
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Updated: merged latest main (CODEOWNERS had been reworked there, so I reconciled), applied the fallback/security/co-owner/self-guard feedback, and marked ready for review. @MajorLift could you re-review when you get a chance? Follow-up PR coming to add the AI engineering team once it's created. Still needs owner confirmation for |
| # that agreement and can only be approved by maintainers of the repo. | ||
| # Note: As the highest-priority entry, this rule should always be placed | ||
| # at the very bottom of the CODEOWNERS file. | ||
| /.github/CODEOWNERS @abretonc7s @MajorLift @cryptotavares @AugmentedMode |
There was a problem hiding this comment.
you can remove @AugmentedMode (that was Jacob and he is no longer working for MetaMask)
There was a problem hiding this comment.
Removed @AugmentedMode from the self-guard line, thanks. Pushed.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Most of the domain owners here won't get review requests. GitHub requires a code-owner team to have write access to the repo itself, even when its members already have it through another team. GitHub's CODEOWNERS check currently rejects the teams below:
Could we get these teams write access to the repo, so the ownership takes effect? |
Summary
.github/CODEOWNERSmapping for current skills domains using MetaMask GitHub teams where obvious.analyticsandplatform, so pending work does not land ownerless./domains/agentic/ownership by@MetaMask/perps.Notes for reviewers
coding,general,pr-workflow, andweb3-tools.analyticsshould be owned by@MetaMask/performance-councilor another team.platformshould use@MetaMask/extension-platform,@MetaMask/core-platform, or a different wallet platform owner.Test plan
gh api orgs/MetaMask/teamsbefore drafting.Made with Cursor