Skip to content

chore: add first-pass domain CODEOWNERS - #59

Merged
dylanbutler1 merged 4 commits into
mainfrom
add-domain-codeowners
Nov 18, 2026
Merged

dylanbutler1 merged 4 commits into
mainfrom
add-domain-codeowners

Conversation

@afadhel-c

Copy link
Copy Markdown
Contributor

Summary

  • Adds a first-pass .github/CODEOWNERS mapping for current skills domains using MetaMask GitHub teams where obvious.
  • Includes domains that are present in open PRs, such as analytics and platform, so pending work does not land ownerless.
  • Preserves the existing legacy /domains/agentic/ ownership by @MetaMask/perps.

Notes for reviewers

  • This is intentionally a first pass based on the domain/team spreadsheet and available GitHub team slugs.
  • Please confirm or correct horizontal domain owners for coding, general, pr-workflow, and web3-tools.
  • Please confirm whether analytics should be owned by @MetaMask/performance-council or another team.
  • Please confirm whether platform should use @MetaMask/extension-platform, @MetaMask/core-platform, or a different wallet platform owner.

Test plan

  • Not run; CODEOWNERS-only change.
  • Verified target team slugs with gh api orgs/MetaMask/teams before drafting.

Made with Cursor

Comment thread .github/CODEOWNERS Outdated
/domains/portfolio/ @MetaMask/portfolio

# Domains currently present or pending in open PRs.
/domains/analytics/ @MetaMask/performance-council

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be data council? @gauthierpetetin @NicolasMassart

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • We should also separate Segment/Metametrics from Sentry/Grafana. I added the analytics domain in Add analytics domain: Sentry quota, MCP queries, instrumentation #41 as a catch-all, but the PR covers subjects outside of data council's perview.
  • We should probably add engineering teams as co-owners so the councils aren't bothered by frequent low-priority requests.
Suggested change
/domains/analytics/ @MetaMask/performance-council
/domains/analytics/ @MetaMask/data-council @MetaMask/extension-platform @MetaMask/mobile-platform @MetaMask/core-platform
/domains/observability/ @MetaMask/sre @MetaMask/api-platform @MetaMask/extension-platform @MetaMask/mobile-platform @MetaMask/core-platform

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done: analytics is now owned by @MetaMask/data-council with the extension/mobile/core platform teams as co-owners (per Major's suggestion).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied: analytics and observability are split, and engineering teams are co-owners on both.

Comment thread .github/CODEOWNERS Outdated

# Domains currently present or pending in open PRs.
/domains/analytics/ @MetaMask/performance-council
/domains/platform/ @MetaMask/extension-platform @MetaMask/core-platform

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we separate domains into "extension" and "mobile" @v-goyal @MajorLift @andrepimenta

@MajorLift MajorLift Jun 30, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea is to use repo overlays for repo-specific overrides, and by default consolidate content that overlaps e.g. react/redux practices, consuming core packages, release workflows, testing etc. -- especially where we'd want to ensure that agent behavior doesn't diverge between clients/repos.

Something like the following would also work, but I can see it tending towards duplication and fragmentation without active curation.

Suggested change
/domains/platform/ @MetaMask/extension-platform @MetaMask/core-platform
/domains/platform-core/ @MetaMask/extension-platform @MetaMask/mobile-platform @MetaMask/core-platform
/domains/platform-clients/ @MetaMask/extension-platform @MetaMask/mobile-platform @MetaMask/core-platform
/domains/platform-extension/ @MetaMask/extension-platform @MetaMask/core-platform
/domains/platform-mobile/ @MetaMask/mobile-platform @MetaMask/core-platform

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping a single platform domain for now, per Major's overlay rationale (repo-specific overrides via overlays). Extension/mobile-specific files under platform keep their own owners. Can split later if it fragments.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping one platform domain for now, with overlays for repo-specific content, to avoid duplication/fragmentation.

Comment thread .github/CODEOWNERS Outdated
/domains/ui/ @MetaMask/design-system-engineers @MetaMask/design-system
/domains/coding/ @MetaMask/engineering
/domains/pr-workflow/ @MetaMask/engineering
/domains/general/ @MetaMask/engineering

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than MetaMask/engineering, maybe we should create a @MetaMask/ai-engineering group

@NicolasMassart NicolasMassart Jun 30, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is metamask engineering like everyone?
If so, why not not adding CO at all?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NicolasMassart It's still a useful layer of branch protection, as long as @MetaMask/engineering is smaller than the set of users with write access to this repo.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MetaMask/ai-engineering doesn't exist yet. I'll open a follow-up PR to swap it in once the team is created. For now engineering stays as a co-owner on performance/ui; coding, pr-workflow, general now route to the platform teams (matches current main).

Comment thread .github/CODEOWNERS Outdated

# Legacy/experimental.
# ADR-58/recipe skills are experimental but owned by Perps during rollout.
/domains/agentic/ @MetaMask/perps

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should include Arthur, @MajorLift, @cryptotavares @AugmentedMode

@MajorLift MajorLift Jun 30, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any CODEOWNERS file needs to guard itself as its highest-priority entry. The very last lines should look something like this:

Suggested change
/domains/agentic/ @MetaMask/perps
/domains/agentic/ @abretonc7s @MajorLift @cryptotavares @AugmentedMode
# The CODEOWNERS file constitutes an agreement amongst organization
# admins and maintainers to restrict approval capabilities to a subset
# of contributors. Modifications to this file result in a modification of
# that agreement and can only be approved by maintainers of the repo.
# Note: As the highest-priority entry, this rule should always be placed
# at the very bottom of the CODEOWNERS file.
/.github/CODEOWNERS @abretonc7s @MajorLift @cryptotavares @AugmentedMode

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should also be an entry to guard the @metamask/skills package. Although maybe we can defer this until v1.0 release to make development easier.

Suggested change
/domains/agentic/ @MetaMask/perps
/domains/agentic/ @MetaMask/perps
# Changes to the `@metamask/skills` npm package require review from repo maintainers.
/tools/ @abretonc7s @MajorLift @cryptotavares @AugmentedMode

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added: maintainers (@abretonc7s @MajorLift @cryptotavares @AugmentedMode) now own /.github/CODEOWNERS as the final entry.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied: CODEOWNERS self-guard added as the last line.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deferring /tools/ maintainer-only ownership until v1.0 as you suggested; it stays with the platform teams for now.

Comment thread .github/CODEOWNERS Outdated
/domains/coding/ @MetaMask/engineering
/domains/pr-workflow/ @MetaMask/engineering
/domains/general/ @MetaMask/engineering
/domains/web3-tools/ @MetaMask/developer-relations

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about this one, but also don't have a better suggestion

Comment thread .github/CODEOWNERS Outdated

# Legacy/experimental.
# ADR-58/recipe skills are experimental but owned by Perps during rollout.
/domains/agentic/ @MetaMask/perps

@MajorLift MajorLift Jun 30, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any CODEOWNERS file needs to guard itself as its highest-priority entry. The very last lines should look something like this:

Suggested change
/domains/agentic/ @MetaMask/perps
/domains/agentic/ @abretonc7s @MajorLift @cryptotavares @AugmentedMode
# The CODEOWNERS file constitutes an agreement amongst organization
# admins and maintainers to restrict approval capabilities to a subset
# of contributors. Modifications to this file result in a modification of
# that agreement and can only be approved by maintainers of the repo.
# Note: As the highest-priority entry, this rule should always be placed
# at the very bottom of the CODEOWNERS file.
/.github/CODEOWNERS @abretonc7s @MajorLift @cryptotavares @AugmentedMode

@MajorLift MajorLift left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • We should add default fallbacks at the top.
  • Add more co-owners entries. Note that sole ownership means all contributions to that domain/path are blocked by review from the owners. This is great if strict enforcement is the goal, but not if codeowners are likely to be overwhelmed with low-priority review requests.

Comment thread .github/CODEOWNERS Outdated
@@ -1,3 +1,31 @@
# GitHub code ownership for MetaMask skills.
# This is a first-pass domain mapping intended for domain-owner review.

@MajorLift MajorLift Jun 30, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For branch protection and security:

Suggested change
# This is a first-pass domain mapping intended for domain-owner review.
# By default, executable files in distributable paths require security review.
# This rule is intended as a fallback and can be overridden by subsequent lines.
/domains/ @MetaMask/security-liaisons @MetaMask/policy-reviewers
/domains/**/scripts/ @MetaMask/application-security @MetaMask/security-liaisons @MetaMask/policy-reviewers
/domains/**/adapters/ @MetaMask/application-security @MetaMask/security-liaisons @MetaMask/policy-reviewers
# By default, markdown files in distributable paths do not require codeowner review.
# This rule is intended as a fallback, and can be overridden by subsequent lines.
/domains/**/*.md
/domains/**/*.mdc

The last rule overrides the ones at the top, so security team members will not be bothered for review on markdown files.

@MajorLift MajorLift Jun 30, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving this at the top makes it a fallback that will mostly be overridden by domain owners, but depending on how strict we want to make security review, we could move the following lines to the bottom of the file to enforce review on all executable files.

/domains/**/scripts/ @MetaMask/application-security @MetaMask/security-liaisons @MetaMask/policy-reviewers 
/domains/**/adapters/ @MetaMask/application-security @MetaMask/security-liaisons @MetaMask/policy-reviewers 

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied: security fallbacks and the markdown override are at the top, so domain owners override them.

Comment thread .github/CODEOWNERS Outdated
/domains/platform/ @MetaMask/extension-platform @MetaMask/core-platform

# Horizontal skills domains.
/domains/performance/ @MetaMask/performance-council

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/domains/performance/ @MetaMask/performance-council
/domains/performance/ @MetaMask/performance-council @MetaMask/engineering

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied.

Comment thread .github/CODEOWNERS Outdated
# Horizontal skills domains.
/domains/performance/ @MetaMask/performance-council
/domains/testing/ @MetaMask/qa
/domains/ui/ @MetaMask/design-system-engineers @MetaMask/design-system

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/domains/ui/ @MetaMask/design-system-engineers @MetaMask/design-system
/domains/ui/ @MetaMask/design-system-engineers @MetaMask/design-system @MetaMask/engineering

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@afadhel-c
afadhel-c marked this pull request as ready for review November 17, 2026 17:15
@afadhel-c

Copy link
Copy Markdown
Contributor Author

Updated: merged latest main (CODEOWNERS had been reworked there, so I reconciled), applied the fallback/security/co-owner/self-guard feedback, and marked ready for review. @MajorLift could you re-review when you get a chance? Follow-up PR coming to add the AI engineering team once it's created. Still needs owner confirmation for coding, general, pr-workflow, web3-tools.

Comment thread .github/CODEOWNERS Outdated
# that agreement and can only be approved by maintainers of the repo.
# Note: As the highest-priority entry, this rule should always be placed
# at the very bottom of the CODEOWNERS file.
/.github/CODEOWNERS @abretonc7s @MajorLift @cryptotavares @AugmentedMode

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can remove @AugmentedMode (that was Jacob and he is no longer working for MetaMask)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed @AugmentedMode from the self-guard line, thanks. Pushed.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@MajorLift

MajorLift commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Most of the domain owners here won't get review requests.

GitHub requires a code-owner team to have write access to the repo itself, even when its members already have it through another team. GitHub's CODEOWNERS check currently rejects the teams below:

MetaMask/api-platform MetaMask/application-security MetaMask/card MetaMask/core-platform MetaMask/data-council MetaMask/design-system MetaMask/design-system-engineers MetaMask/developer-relations MetaMask/engagement MetaMask/extension-platform MetaMask/metamask-assets MetaMask/mobile-platform MetaMask/notifications MetaMask/performance-council MetaMask/policy-reviewers MetaMask/portfolio MetaMask/qa MetaMask/security-liaisons MetaMask/sre MetaMask/swaps-engineers MetaMask/transactions MetaMask/wallet-api-platform-engineers MetaMask/web3auth MetaMask/web3auth-platform

Could we get these teams write access to the repo, so the ownership takes effect?

@andrepimenta
andrepimenta enabled auto-merge (squash) November 18, 2026 12:14
@dylanbutler1
dylanbutler1 enabled auto-merge (squash) November 18, 2026 20:15
@dylanbutler1
dylanbutler1 merged commit e72d9ab into main Nov 18, 2026
28 checks passed
@dylanbutler1
dylanbutler1 deleted the add-domain-codeowners branch November 18, 2026 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants