You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
GetManyClients paging defaults are wrong and NextUrl double-counts #51
Problem:var page = request.Page > 0 ? request.Page : 10; treats Page as a page size, defaulting to 10 — but it is a page number everywhere else (NextUrl = page={request.Page + 1}). So Take(page) takes "page-number" rows, and Skip(skip) uses a raw Skip field that is never multiplied by page size. Paging returns overlapping/incorrect windows.
Fix: Separate page number from page size, compute Skip((page-1) * pageSize).Take(pageSize), and build NextUrl from the same variables.
If we skip it: Listing clients returns wrong, overlapping result pages.
Resolved by PR #86 (merged into main as commit c295a0f via epic PR #81). Fix: corrected GetManyClients paging (1-based page number, page size, consistent NextUrl).
Activity
fix(api): correct GetManyClients paging (#51)
fix(api): correct GetManyClients paging (#51) (#86)
fix(clients): search GetManyClients by SearchTerm not whole request
fix(clients): search GetManyClients by SearchTerm not whole request (#88
docs: update steering for must-fix changes (#45-#51) (#89)
docs(specs): add must-fix specs for #45-#51 (+ deferred #79, README #80)
fix(clients): search GetManyClients by SearchTerm not whole request (#88
docs: update steering for must-fix changes (#45-#51) (#89)
brinehart commentedon Nov 2, 2026
Resolved by PR #86 (merged into
mainas commit c295a0f via epic PR #81). Fix: corrected GetManyClients paging (1-based page number, page size, consistent NextUrl).