Skip to content

[JitDiff X64] [Copilot] Remove unsafe code from BigInteger.TryWriteBigEndian ... #1795

Description

@MihuBot

Job completed in 2 minutes 22 seconds (remote runner delay: 0 seconds).
dotnet/runtime#124858

Main commit: dotnet/runtime@0fe50ea
PR commit: dotnet/runtime@e6c1f5a

Diffs

Found 84 files with textual diffs.

Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 45422209
Total bytes of diff: 45422303
Total bytes of delta: 94 (0.00 % of base)
Total relative delta: -0.14
    diff is a regression.
    relative diff is an improvement.


Top file regressions (bytes):
         264 : System.Runtime.Numerics.dasm (0.17 % of base)

Top file improvements (bytes):
        -170 : System.Net.Sockets.dasm (-0.06 % of base)

2 total files with Code Size differences (1 improved, 1 regressed), 259 unchanged.

Top method regressions (bytes):
         183 (58.10 % of base) : System.Runtime.Numerics.dasm - System.Numerics.BigInteger:System.Numerics.IBinaryInteger<System.Numerics.BigInteger>.TryWriteBigEndian(System.Span`1[byte],byref):bool:this (FullOpts)
          81 (27.93 % of base) : System.Runtime.Numerics.dasm - System.Numerics.BigInteger:System.Numerics.IBinaryInteger<System.Numerics.BigInteger>.TryWriteLittleEndian(System.Span`1[byte],byref):bool:this (FullOpts)

Top method improvements (bytes):
        -170 (-100.00 % of base) : System.Net.Sockets.dasm - System.Net.Sockets.SocketAsyncEngine:TryRegisterSocket(nint,System.Net.Sockets.SocketAsyncContext,byref,byref):bool (FullOpts)

Top method regressions (percentages):
         183 (58.10 % of base) : System.Runtime.Numerics.dasm - System.Numerics.BigInteger:System.Numerics.IBinaryInteger<System.Numerics.BigInteger>.TryWriteBigEndian(System.Span`1[byte],byref):bool:this (FullOpts)
          81 (27.93 % of base) : System.Runtime.Numerics.dasm - System.Numerics.BigInteger:System.Numerics.IBinaryInteger<System.Numerics.BigInteger>.TryWriteLittleEndian(System.Span`1[byte],byref):bool:this (FullOpts)

Top method improvements (percentages):
        -170 (-100.00 % of base) : System.Net.Sockets.dasm - System.Net.Sockets.SocketAsyncEngine:TryRegisterSocket(nint,System.Net.Sockets.SocketAsyncContext,byref,byref):bool (FullOpts)

3 total methods with Code Size differences (1 improved, 2 regressed), 284373 unchanged.

--------------------------------------------------------------------------------

Artifacts:

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions