Skip to content

[JitDiff X64] [EgorBo] Remove more fixed buffers and replace them with Inlin ... #1814

Description

@MihuBot

Job completed in 2 minutes 51 seconds (remote runner delay: 0 seconds).
dotnet/runtime#125574

Main commit: dotnet/runtime@c38f37a
PR commit: EgorBo/runtime-1@76e36a4

Diffs

Diffs
Found 85 files with textual diffs.

Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 45392490
Total bytes of diff: 45392654
Total bytes of delta: 164 (0.00 % of base)
Total relative delta: 0.01
    diff is a regression.
    relative diff is a regression.


Total byte diff includes 159 bytes from reconciling methods
	Base had    0 unique methods,        0 unique bytes
	Diff had   24 unique methods,      159 unique bytes

Top file regressions (bytes):
         103 : System.Text.Encodings.Web.dasm (0.45 % of base)
          58 : System.Net.Quic.dasm (0.04 % of base)
           3 : System.Net.NetworkInformation.dasm (0.01 % of base)

3 total files with Code Size differences (0 improved, 3 regressed), 257 unchanged.

Top method regressions (bytes):
           7 (Infinity of base) : System.Text.Encodings.Web.dasm - <PrivateImplementationDetails>:InlineArrayAsReadOnlySpan[byte,System.Nullable`1[int]](byref,int):System.ReadOnlySpan`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           7 (Infinity of base) : System.Text.Encodings.Web.dasm - <PrivateImplementationDetails>:InlineArrayAsReadOnlySpan[double,System.Nullable`1[int]](byref,int):System.ReadOnlySpan`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           7 (Infinity of base) : System.Text.Encodings.Web.dasm - <PrivateImplementationDetails>:InlineArrayAsReadOnlySpan[int,System.Nullable`1[int]](byref,int):System.ReadOnlySpan`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           7 (Infinity of base) : System.Text.Encodings.Web.dasm - <PrivateImplementationDetails>:InlineArrayAsReadOnlySpan[long,System.Nullable`1[int]](byref,int):System.ReadOnlySpan`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           7 (Infinity of base) : System.Text.Encodings.Web.dasm - <PrivateImplementationDetails>:InlineArrayAsReadOnlySpan[short,System.Nullable`1[int]](byref,int):System.ReadOnlySpan`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           7 (Infinity of base) : System.Text.Encodings.Web.dasm - <PrivateImplementationDetails>:InlineArrayAsReadOnlySpan[System.Nullable`1[int],System.Nullable`1[int]](byref,int):System.ReadOnlySpan`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           7 (Infinity of base) : System.Text.Encodings.Web.dasm - <PrivateImplementationDetails>:InlineArrayAsReadOnlySpan[System.Numerics.Vector`1[float],System.Nullable`1[int]](byref,int):System.ReadOnlySpan`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           7 (Infinity of base) : System.Net.Quic.dasm - <PrivateImplementationDetails>:InlineArrayAsSpan[byte,System.Nullable`1[int]](byref,int):System.Span`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           7 (Infinity of base) : System.Text.Encodings.Web.dasm - <PrivateImplementationDetails>:InlineArrayAsSpan[byte,System.Nullable`1[int]](byref,int):System.Span`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           7 (Infinity of base) : System.Net.Quic.dasm - <PrivateImplementationDetails>:InlineArrayAsSpan[double,System.Nullable`1[int]](byref,int):System.Span`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           7 (Infinity of base) : System.Text.Encodings.Web.dasm - <PrivateImplementationDetails>:InlineArrayAsSpan[double,System.Nullable`1[int]](byref,int):System.Span`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           7 (Infinity of base) : System.Net.Quic.dasm - <PrivateImplementationDetails>:InlineArrayAsSpan[int,System.Nullable`1[int]](byref,int):System.Span`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           7 (Infinity of base) : System.Text.Encodings.Web.dasm - <PrivateImplementationDetails>:InlineArrayAsSpan[int,System.Nullable`1[int]](byref,int):System.Span`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           7 (Infinity of base) : System.Net.Quic.dasm - <PrivateImplementationDetails>:InlineArrayAsSpan[long,System.Nullable`1[int]](byref,int):System.Span`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           7 (Infinity of base) : System.Text.Encodings.Web.dasm - <PrivateImplementationDetails>:InlineArrayAsSpan[long,System.Nullable`1[int]](byref,int):System.Span`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           7 (Infinity of base) : System.Net.Quic.dasm - <PrivateImplementationDetails>:InlineArrayAsSpan[short,System.Nullable`1[int]](byref,int):System.Span`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           7 (Infinity of base) : System.Text.Encodings.Web.dasm - <PrivateImplementationDetails>:InlineArrayAsSpan[short,System.Nullable`1[int]](byref,int):System.Span`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           7 (Infinity of base) : System.Net.Quic.dasm - <PrivateImplementationDetails>:InlineArrayAsSpan[System.Nullable`1[int],System.Nullable`1[int]](byref,int):System.Span`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           7 (Infinity of base) : System.Text.Encodings.Web.dasm - <PrivateImplementationDetails>:InlineArrayAsSpan[System.Nullable`1[int],System.Nullable`1[int]](byref,int):System.Span`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           7 (Infinity of base) : System.Net.Quic.dasm - <PrivateImplementationDetails>:InlineArrayAsSpan[System.Numerics.Vector`1[float],System.Nullable`1[int]](byref,int):System.Span`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           7 (Infinity of base) : System.Text.Encodings.Web.dasm - <PrivateImplementationDetails>:InlineArrayAsSpan[System.Numerics.Vector`1[float],System.Nullable`1[int]](byref,int):System.Span`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           5 (0.86 % of base) : System.Net.Quic.dasm - System.Net.Quic.MsQuicTlsSecret:WriteSecret():this (FullOpts)
           4 (Infinity of base) : System.Text.Encodings.Web.dasm - <PrivateImplementationDetails>:InlineArrayAsReadOnlySpan[System.__Canon,System.Nullable`1[int]](byref,int):System.ReadOnlySpan`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           4 (Infinity of base) : System.Net.Quic.dasm - <PrivateImplementationDetails>:InlineArrayAsSpan[System.__Canon,System.Nullable`1[int]](byref,int):System.Span`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           4 (Infinity of base) : System.Text.Encodings.Web.dasm - <PrivateImplementationDetails>:InlineArrayAsSpan[System.__Canon,System.Nullable`1[int]](byref,int):System.Span`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           2 (0.16 % of base) : System.Net.NetworkInformation.dasm - System.Net.NetworkInformation.LinuxNetworkInterface:GetLinuxNetworkInterfaces():System.Net.NetworkInformation.NetworkInterface[] (FullOpts)
           1 (1.09 % of base) : System.Net.NetworkInformation.dasm - System.Net.NetworkInformation.IPAddressUtil:GetIPAddressFromNativeInfo(ptr):System.Net.IPAddress (FullOpts)

Top method improvements (bytes):
          -3 (-0.79 % of base) : System.Text.Encodings.Web.dasm - System.Text.Encodings.Web.OptimizedInboxTextEncoder+AsciiPreescapedData:PopulatePreescapedData(byref,System.Text.Encodings.Web.ScalarEscaperBase):this (FullOpts)

Top method regressions (percentages):
           7 (Infinity of base) : System.Text.Encodings.Web.dasm - <PrivateImplementationDetails>:InlineArrayAsReadOnlySpan[byte,System.Nullable`1[int]](byref,int):System.ReadOnlySpan`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           7 (Infinity of base) : System.Text.Encodings.Web.dasm - <PrivateImplementationDetails>:InlineArrayAsReadOnlySpan[double,System.Nullable`1[int]](byref,int):System.ReadOnlySpan`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           7 (Infinity of base) : System.Text.Encodings.Web.dasm - <PrivateImplementationDetails>:InlineArrayAsReadOnlySpan[int,System.Nullable`1[int]](byref,int):System.ReadOnlySpan`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           7 (Infinity of base) : System.Text.Encodings.Web.dasm - <PrivateImplementationDetails>:InlineArrayAsReadOnlySpan[long,System.Nullable`1[int]](byref,int):System.ReadOnlySpan`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           7 (Infinity of base) : System.Text.Encodings.Web.dasm - <PrivateImplementationDetails>:InlineArrayAsReadOnlySpan[short,System.Nullable`1[int]](byref,int):System.ReadOnlySpan`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           4 (Infinity of base) : System.Text.Encodings.Web.dasm - <PrivateImplementationDetails>:InlineArrayAsReadOnlySpan[System.__Canon,System.Nullable`1[int]](byref,int):System.ReadOnlySpan`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           7 (Infinity of base) : System.Text.Encodings.Web.dasm - <PrivateImplementationDetails>:InlineArrayAsReadOnlySpan[System.Nullable`1[int],System.Nullable`1[int]](byref,int):System.ReadOnlySpan`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           7 (Infinity of base) : System.Text.Encodings.Web.dasm - <PrivateImplementationDetails>:InlineArrayAsReadOnlySpan[System.Numerics.Vector`1[float],System.Nullable`1[int]](byref,int):System.ReadOnlySpan`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           7 (Infinity of base) : System.Net.Quic.dasm - <PrivateImplementationDetails>:InlineArrayAsSpan[byte,System.Nullable`1[int]](byref,int):System.Span`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           7 (Infinity of base) : System.Text.Encodings.Web.dasm - <PrivateImplementationDetails>:InlineArrayAsSpan[byte,System.Nullable`1[int]](byref,int):System.Span`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           7 (Infinity of base) : System.Net.Quic.dasm - <PrivateImplementationDetails>:InlineArrayAsSpan[double,System.Nullable`1[int]](byref,int):System.Span`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           7 (Infinity of base) : System.Text.Encodings.Web.dasm - <PrivateImplementationDetails>:InlineArrayAsSpan[double,System.Nullable`1[int]](byref,int):System.Span`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           7 (Infinity of base) : System.Net.Quic.dasm - <PrivateImplementationDetails>:InlineArrayAsSpan[int,System.Nullable`1[int]](byref,int):System.Span`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           7 (Infinity of base) : System.Text.Encodings.Web.dasm - <PrivateImplementationDetails>:InlineArrayAsSpan[int,System.Nullable`1[int]](byref,int):System.Span`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           7 (Infinity of base) : System.Net.Quic.dasm - <PrivateImplementationDetails>:InlineArrayAsSpan[long,System.Nullable`1[int]](byref,int):System.Span`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           7 (Infinity of base) : System.Text.Encodings.Web.dasm - <PrivateImplementationDetails>:InlineArrayAsSpan[long,System.Nullable`1[int]](byref,int):System.Span`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           7 (Infinity of base) : System.Net.Quic.dasm - <PrivateImplementationDetails>:InlineArrayAsSpan[short,System.Nullable`1[int]](byref,int):System.Span`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           7 (Infinity of base) : System.Text.Encodings.Web.dasm - <PrivateImplementationDetails>:InlineArrayAsSpan[short,System.Nullable`1[int]](byref,int):System.Span`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           4 (Infinity of base) : System.Net.Quic.dasm - <PrivateImplementationDetails>:InlineArrayAsSpan[System.__Canon,System.Nullable`1[int]](byref,int):System.Span`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           4 (Infinity of base) : System.Text.Encodings.Web.dasm - <PrivateImplementationDetails>:InlineArrayAsSpan[System.__Canon,System.Nullable`1[int]](byref,int):System.Span`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           7 (Infinity of base) : System.Net.Quic.dasm - <PrivateImplementationDetails>:InlineArrayAsSpan[System.Nullable`1[int],System.Nullable`1[int]](byref,int):System.Span`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           7 (Infinity of base) : System.Text.Encodings.Web.dasm - <PrivateImplementationDetails>:InlineArrayAsSpan[System.Nullable`1[int],System.Nullable`1[int]](byref,int):System.Span`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           7 (Infinity of base) : System.Net.Quic.dasm - <PrivateImplementationDetails>:InlineArrayAsSpan[System.Numerics.Vector`1[float],System.Nullable`1[int]](byref,int):System.Span`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           7 (Infinity of base) : System.Text.Encodings.Web.dasm - <PrivateImplementationDetails>:InlineArrayAsSpan[System.Numerics.Vector`1[float],System.Nullable`1[int]](byref,int):System.Span`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           1 (1.09 % of base) : System.Net.NetworkInformation.dasm - System.Net.NetworkInformation.IPAddressUtil:GetIPAddressFromNativeInfo(ptr):System.Net.IPAddress (FullOpts)
           5 (0.86 % of base) : System.Net.Quic.dasm - System.Net.Quic.MsQuicTlsSecret:WriteSecret():this (FullOpts)
           2 (0.16 % of base) : System.Net.NetworkInformation.dasm - System.Net.NetworkInformation.LinuxNetworkInterface:GetLinuxNetworkInterfaces():System.Net.NetworkInformation.NetworkInterface[] (FullOpts)

Top method improvements (percentages):
          -3 (-0.79 % of base) : System.Text.Encodings.Web.dasm - System.Text.Encodings.Web.OptimizedInboxTextEncoder+AsciiPreescapedData:PopulatePreescapedData(byref,System.Text.Encodings.Web.ScalarEscaperBase):this (FullOpts)

28 total methods with Code Size differences (1 improved, 27 regressed), 284649 unchanged.

--------------------------------------------------------------------------------

Artifacts:

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions