Skip to content

Unit tests failing (OK for now after pinning Zarr) #62

Closed

Description

@valeriupredoi

Our tests are currently failing, see fails - it's very possible new versions of fsspec have changed their API, I will check this now (cheers @davidhassell for alerting me 🍺 )

Activity

  1. self-assigned this
    on Mar 6, 2023
  2. valeriupredoi commented on Mar 6, 2023

    @valeriupredoi
    CollaboratorAuthor

    Correction it's not fspec but zarr - the break appears after zarr>2.13.3

  3. valeriupredoi commented on Mar 6, 2023

    @valeriupredoi
    CollaboratorAuthor

    OK this is the PR causing this - it seems they have forgotten to update the API - I'll raise an Issue zarr-developers/zarr-python#1304

  4. valeriupredoi commented on Mar 6, 2023

    @valeriupredoi
    CollaboratorAuthor

    with 2.13.3 our object is:

    <KVStore: 
    <fsspec.mapping.FSMap object at 0x7ff62cd21630>
     at 0x7ff62cd22140>
    

    with 2.13.6 our object becomes:

    <zarr.storage.FSStore object at 0x7f3120e6d5d0>
    

    so there is a difference in the way the object is treated from one version to another 🤦‍♂️

  5. valeriupredoi commented on Mar 6, 2023

    @valeriupredoi
    CollaboratorAuthor

    @davidhassell @bnlawrence I opened this zarr-developers/zarr-python#1362 and right now am gonna pin zarr in our env 👍

  6. valeriupredoi commented on Mar 6, 2023

    @valeriupredoi
    CollaboratorAuthor

    we now have a working setup again after #63 but am keeping this open still - am working with the Zarr folks in that issue, and will close ony when we can unpin Zarr and either implement what they recommend, or they fix their bug 👍

  7. changed the title [-]Unit tests failing[/-] [+]Unit tests failing (OK for now after pinning Zarr)[/+] on Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingtestingtesting duh

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions