Skip to content

UseNLog should fallback after checking ContentRoot for NLog.config - #765

Merged
snakefoot merged 1 commit into
NLog:masterfrom
snakefoot:master
Sep 23, 2024
Merged

snakefoot merged 1 commit into
NLog:masterfrom
snakefoot:master

Conversation

@snakefoot

@snakefoot snakefoot commented Sep 23, 2024 •

Copy link
Copy Markdown
Contributor

Fix bug introduced with NLog.Extensions.Logging v5.3.8 (#714 + #715) and restore behavior like #617

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.51%. Comparing base (9106fa3) to head (a1c667c).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #765      +/-   ##
==========================================
- Coverage   81.53%   81.51%   -0.03%     
==========================================
  Files          19       19              
  Lines        1809     1807       -2     
  Branches      322      320       -2     
==========================================
- Hits         1475     1473       -2     
  Misses        190      190              
  Partials      144      144              
Flag Coverage Δ
81.51% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@snakefoot
snakefoot merged commit 8992127 into NLog:master Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants