Skip to content

Create theory_405.yaml - #14

Closed
felixhekhorn wants to merge 1 commit into
mainfrom
nlo_dis_grids
Closed

Create theory_405.yaml#14
felixhekhorn wants to merge 1 commit into
mainfrom
nlo_dis_grids

Conversation

@felixhekhorn

Copy link
Copy Markdown
Contributor

port of NNPDF/pinecards#166

looks good to me by the way

@alecandido

Copy link
Copy Markdown
Contributor

Yes, it should be fine. At some point, I want to write a small function that downloads the theory db (either the SQL from the repo or the HTML table) and cache it locally, such that we can load from there.

Maybe we will still need some extra parameters, but these can be treated separately.

@andreab1997

Copy link
Copy Markdown
Contributor

The theory card should be good. However when using it to compute the NLO DIS grids, it happens than the computed grids contain also the NNLO terms. Moreover, checking with pineappl diff, they are exactly the same as the theory 400 grids. Does this make sense to you? (cc @scarlehoff)

@alecandido

Copy link
Copy Markdown
Contributor

it happens than the computed grids contain also the NNLO terms

This is fine, because it is FONLL-B

@andreab1997

Copy link
Copy Markdown
Contributor

The theory card should be good. However when using it to compute the NLO DIS grids, it happens than the computed grids contain also the NNLO terms. Moreover, checking with pineappl diff, they are exactly the same as the theory 400 grids. Does this make sense to you? (cc @scarlehoff)

Ok sorry, it seems that this was an error. So, everything should be fine as far as I understood.

@codecov

codecov Bot commented Feb 16, 2023

Copy link
Copy Markdown

Codecov Report

Base: 29.61% // Head: 29.61% // No change to project coverage 👍

Coverage data is based on head (149910f) compared to base (302568c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #14   +/-   ##
=======================================
  Coverage   29.61%   29.61%           
=======================================
  Files          24       24           
  Lines        1246     1246           
=======================================
  Hits          369      369           
  Misses        877      877           
Flag Coverage Δ
unittests 29.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alecandido alecandido left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's a bit outdated, but if still relevant it's fine.

If it's not relevant any longer, please close the PR.

@felixhekhorn

Copy link
Copy Markdown
Contributor Author

It is indeed outdated and does not correspond to theory 405 any longer (no b displacement) ... I now think, we should not store theory cards here. This should be done on a more global level instead ... see also NNPDF/nnpdf#1705 (cc @scarlehoff )

just to stress the point that we should do something sooner or later: on Friday @Radonirinaunimi was asking me for an official theory card and all I could do was to reply: "please ask @andreab1997, he knows"

@felixhekhorn
felixhekhorn deleted the nlo_dis_grids branch June 19, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants