Skip to content

fix(specdec): generate all multimodal sources and pad VLM batches - #2195

Open
skierat wants to merge 1 commit into
haoguo/dflash-cosmos3-launcher-examplefrom
skierat/dflash-cosmos3-launcher-example
Open

fix(specdec): generate all multimodal sources and pad VLM batches#2195
skierat wants to merge 1 commit into
haoguo/dflash-cosmos3-launcher-examplefrom
skierat/dflash-cosmos3-launcher-example

Conversation

@skierat

@skierat skierat commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Type of change: ?

Usage

# Add a code snippet demonstrating how to use this

Testing

Before your PR is "Ready for review"

Make sure you read and follow Contributor guidelines and your commits are signed (git commit -s -S).

Make sure you read and follow the Security Best Practices (e.g. avoiding hardcoded trust_remote_code=True, torch.load(..., weights_only=False), pickle, etc.).

  • Is this change backward compatible?: ✅ / ❌ / N/A
  • If you copied code from any other sources or added a new PIP dependency, did you follow guidance in CONTRIBUTING.md: ✅ / ❌ / N/A
  • Did you write any new necessary tests?: ✅ / ❌ / N/A
  • Did you update Changelog?: ✅ / ❌ / N/A
  • Did you get Claude approval on this PR?: ✅ / ❌ / N/A

Additional Information

Signed-off-by: Slawomir Kierat <skierat@nvidia.com>
@skierat
skierat requested review from a team as code owners August 14, 2026 16:38
@skierat
skierat requested review from AAnoosheh and removed request for a team August 14, 2026 16:38
@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (3)
  • main
  • release/.*
  • feature/.*

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: e9e50298-3f85-4d0b-8ec9-531d0ac0523e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (haoguo/dflash-cosmos3-launcher-example@ed68258). Learn more about missing BASE report.

Additional details and impacted files
@@                            Coverage Diff                            @@
##             haoguo/dflash-cosmos3-launcher-example    #2195   +/-   ##
=========================================================================
  Coverage                                          ?   77.76%           
=========================================================================
  Files                                             ?      521           
  Lines                                             ?    61264           
  Branches                                          ?        0           
=========================================================================
  Hits                                              ?    47640           
  Misses                                            ?    13624           
  Partials                                          ?        0           
Flag Coverage Δ
examples 43.02% <ø> (?)
gpu 58.62% <ø> (?)
regression 14.97% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant