fix(sandbox): verify session-export download wrote a file before recording a bundle (#7367) by Dongni-Yang · Pull Request #7371 · NVIDIA/NemoClaw

Dongni-Yang · 2026-07-22T06:53:51Z

Summary

openshell sandbox download has an upstream process-exit race (NVIDIA/OpenShell) that can report success (exit 0) even when the transfer was rejected or failed and no file was written. NemoClaw's session export/backup (sessions/export.ts) trusted that exit code alone, so a dropped exit code could record a rejected or partial download as a valid session bundle. This adds a NemoClaw-side artifact check after each trusted download.

Related Issue

Refs #7367. This is a defensive mitigation on the NemoClaw side, not the root-cause fix — the exit-code race lives in OpenShell's openshell sandbox download (the #[tokio::main] teardown path in crates/openshell-cli), so #7367 is closed on the NemoClaw board as upstream-owned; the root-cause CLI exit-code fix (making openshell sandbox download exit non-zero on a rejected path) is tracked in NVIDIA/OpenShell. Reproduced against a source build of OpenShell v0.0.85 (the version in #7367): the /sandbox path-traversal guard correctly rejects the source and prints an error, but the process intermittently exits 0.

Changes

New src/lib/actions/sandbox/sessions/download-verify.ts — assertDownloadedFile(download, hostPath, { remoteLabel, sandboxName, requireNonEmpty? }) re-checks the outcome against the file system after a sandbox download: rejects a non-zero exit (preserving the previous Failed to download '<x>' from sandbox '<y>' (exit <n>). wording), and rejects an exit-0 that produced no file, a non-regular file, or (when requireNonEmpty) an empty file.
sessions/export.ts — the three trusted download sites now call assertDownloadedFile instead of only checking the exit status:
- OpenClaw tar bundle → requireNonEmpty: true (a bundle of ≥1 file is never legitimately empty; the zero-session case is already refused earlier).
- OpenClaw dir per-file → existence + regular-file only (a session file's size is not constrained).
- hermes bundle → existence + regular-file only, since a zero-session hermes export can legitimately be empty (no upstream zero-session guard on that path).
Tests: a new download-verify.test.ts (real tmpdir, one case per branch) plus export-level regressions for the tar (missing + empty), dir (missing), and hermes (missing) sites, each asserting the export aborts and still cleans up the in-sandbox staging file.

Out of scope (verified, not gaps): the user-facing sandbox download command supports directory downloads and streams to the user; dashboard.ts / selection-drift.ts already re-check the file system after their downloads. These are documented in the review notes, not left silently.

Type of Change

Code change (feature, bug fix, or refactor)
Code change with doc updates
Doc only (prose changes, no code sample modifications)
Doc only (includes code sample changes)

Quality Gates

Tests added or updated for changed behavior
Existing tests cover changed behavior — justification:
Tests not applicable — justification:
Docs updated for user-facing behavior changes
Docs not applicable — justification: no user-facing surface changes; the export still succeeds on a real transfer and fails with a clearer message when the artifact is missing.
Sensitive paths changed (security, policy, credentials, preflight, onboarding, inference, runner, sandbox, or messaging)
Sensitive-path review completed or maintainer-approved waiver recorded — reviewer/approval link/justification: awaiting maintainer review on this PR
Non-success, skipped, or missing CI check accepted by maintainer — check name, approval link, and follow-up issue:

Verification

PR description includes a Signed-off-by: line and every commit appears as Verified in GitHub
Normal pre-commit, commit-msg, and pre-push hooks passed, or npm run check:diff passed when hooks were skipped or unavailable — npm run check:diff passed (hooks skipped locally; commitlint + Biome + TypeScript all green)
Targeted behavior tests pass for the current change set, or tests are marked not applicable above — npx vitest run --project cli src/lib/actions/sandbox/sessions/download-verify.test.ts src/lib/actions/sandbox/sessions/export.test.ts → 39/39; test/sandbox-sessions-export-cli.test.ts → 13/13
Applicable broad gate passed — not applicable (targeted change)
Quality Gates section completed with required justifications or waivers
No secrets, API keys, or credentials committed

Signed-off-by: Dongni-Yang dongniy@nvidia.com

🤖 Generated with Claude Code

Summary by CodeRabbit

Bug Fixes
- Improved sandbox session exports by validating downloaded artifacts before publication, including file existence, correct file type, and optional “non-empty” enforcement.
- Prevented successful download statuses from producing incomplete or empty outputs (including exit-0/no-write and empty bundle/file cases).
- Ensured staging cleanup and safe rename flow still complete even when validation fails.
Tests
- Added coverage for multiple download outcome scenarios to ensure correct acceptance/rejection behavior.
- Updated export CLI tests to reflect staging-path behavior and confirm final output artifacts are written as expected.

…rding a bundle (#7367) `openshell sandbox download` has an upstream process-exit race (NVIDIA/OpenShell) that can report success (exit 0) even when the transfer was rejected or failed and no file was written. NemoClaw's session export/backup trusted that exit code alone, so a dropped code could record a rejected or partial download as a valid session bundle. Add assertDownloadedFile(), which re-checks the outcome against the file system after each trusted `sandbox download`: the destination must exist as a regular file (and, for bundles that are never legitimately empty, be non-empty). Wire it into the three export download sites (OpenClaw tar, OpenClaw per-file dir, hermes). The hermes site verifies existence only, since a zero-session hermes export can legitimately be empty. This is a NemoClaw-side defensive mitigation; the root-cause exit-code race remains an upstream OpenShell fix, so this refs rather than closes the issue. Refs #7367 Signed-off-by: Dongni-Yang <dongniy@nvidia.com> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

coderabbitai · 2026-07-22T06:54:12Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 3bd126db-1faf-435b-a22d-5efc4b95f37e

📥 Commits

Reviewing files that changed from the base of the PR and between 0f01fcc and 8507e7c.

📒 Files selected for processing (2)

src/lib/actions/sandbox/sessions/export.test.ts
test/sandbox-sessions-export-cli.test.ts

🚧 Files skipped from review as they are similar to previous changes (2)

test/sandbox-sessions-export-cli.test.ts
src/lib/actions/sandbox/sessions/export.test.ts

📝 Walkthrough

Walkthrough

Adds filesystem-aware download verification and integrates staged artifact validation into OpenClaw and Hermes session exports. Tests cover missing, directory, empty, non-empty, stale-destination, and non-zero-status outcomes.

Changes

Sandbox download verification

Layer / File(s)	Summary
Download verification utility `src/lib/actions/sandbox/sessions/download-verify.ts`, `src/lib/actions/sandbox/sessions/download-verify.test.ts`	Defines verification contracts, checks download status and host file metadata, and tests success and failure cases.
Session export verification integration `src/lib/actions/sandbox/sessions/export.ts`	Downloads OpenClaw and Hermes artifacts into staging paths, verifies them before renaming, applies format-specific empty-file rules, and cleans up staging directories.
Export failure and cleanup coverage `src/lib/actions/sandbox/sessions/export.test.ts`, `test/sandbox-sessions-export-cli.test.ts`	Adds filesystem mocks and regression coverage for missing or empty artifacts, stale destinations, cleanup, staging paths, and final publication.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Suggested labels: area: security, bug-fix

Suggested reviewers: apurvvkumaria, cv

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main change: verifying session-export downloads produced a file before finalizing the bundle.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch dongniy/7367-download-artifact-verify

_{Comment @coderabbitai help to get the list of available commands.}

github-code-quality · 2026-07-22T06:54:42Z

Code Coverage Overview

Languages: TypeScript

TypeScript / code-coverage/plugin

The overall coverage in commit 8507e7c in the dongniy/7367-downloa... branch remains at 96%, unchanged from commit d13e34a in the main branch.

TypeScript / code-coverage/cli

The overall coverage in commit 8507e7c in the dongniy/7367-downloa... branch remains at 80%, unchanged from commit d13e34a in the main branch.

Show a code coverage summary of the most impacted files.

File	`main` d13e34a	`dongniy/7367-downloa...` 8507e7c	+/-
`src/lib/state/m...-acquisition.ts`	89%	84%	-5%
`src/lib/platform.ts`	89%	84%	-5%
`src/lib/onboard...host-anchors.ts`	94%	90%	-4%
`src/lib/actions...eway-restart.ts`	93%	90%	-3%
`src/lib/messagi...flow-planner.ts`	93%	93%	0%
`src/lib/onboard...er-gpu-route.ts`	91%	92%	+1%
`src/lib/domain/.../connect-env.ts`	89%	97%	+8%
`src/lib/onboard...atch-adapter.ts`	83%	100%	+17%
`src/lib/onboard...box-prebuild.ts`	69%	88%	+19%
`src/lib/actions...nload-verify.ts`	0%	100%	+100%

_{Updated July 23, 2026 02:16 UTC}

coderabbitai

Actionable comments posted: 4

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/lib/actions/sandbox/sessions/download-verify.ts`:
- Around line 15-20: Update the contract comment for requireNonEmpty to remove
Hermes exports from the examples described as never legitimately empty, while
retaining the guidance for gzip tarballs and individual session files.
- Around line 49-52: Move the fs.statSync(hostPath) call out of the action
helper and into an appropriate adapter under src/lib/adapters. Update the
download verification flow to obtain filesystem metadata through that adapter
while preserving the existing validation and error-handling behavior around
stat.

In `@src/lib/actions/sandbox/sessions/export.test.ts`:
- Around line 523-530: Ensure the mkdirSync spy created in the
exportSandboxSessions test is restored even when the rejection assertion fails.
Wrap the await expect assertion in a try/finally that calls
mkdirSpy.mockRestore(), or add equivalent restoration to shared cleanup while
preserving the existing assertion behavior.

In `@src/lib/actions/sandbox/sessions/export.ts`:
- Around line 218-221: Prevent stale files from being accepted after an
exit-0/no-write download. In src/lib/actions/sandbox/sessions/export.ts lines
218-221, use a fresh per-export staging path for the download, run
assertDownloadedFile against it, then publish it to localPath only after
verification. In src/lib/actions/sandbox/sessions/download-verify.ts lines
37-69, document or enforce that the verified output path must be fresh. In
src/lib/actions/sandbox/sessions/export.test.ts lines 517-531, add a regression
test covering a pre-existing non-empty destination with an exit-0/no-write
download and assert that the export fails.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 78327a0d-49d1-4259-b835-26495fea028e

📥 Commits

Reviewing files that changed from the base of the PR and between 6d0bc58 and ca03e01.

📒 Files selected for processing (4)

src/lib/actions/sandbox/sessions/download-verify.test.ts
src/lib/actions/sandbox/sessions/download-verify.ts
src/lib/actions/sandbox/sessions/export.test.ts
src/lib/actions/sandbox/sessions/export.ts

github-actions · 2026-07-22T06:58:13Z

PR Review Advisor — Informational

Advisor assessment: Informational / high confidence
Next action: Review the warnings below.
Findings: 0 blockers · 1 warning · 0 suggestions
Status: Canonical ledger: 0 blocker(s), 1 warning(s), 0 suggestion(s).

Model lanes

GPT-5.6 Terra (primary): Completed · high confidence · 0 blockers · 1 warning · 0 suggestions
Nemotron 3 Ultra (second opinion): Completed · high confidence · 0 blockers · 0 warnings · 0 suggestions
Model comparison: normalized findings differ; normalized E2E selections differ; Nemotron reported the same number of blockers, 1 fewer warning, the same number of suggestions.

Nemotron output stays in workflow artifacts and does not change the assessment above.

E2E guidance

Advisory only. E2E / PR Gate selects and runs jobs independently.

Recommended E2E: onboard-repair, onboard-resume

1 optional E2E recommendation

sessions-agents-cli

1 warning · 0 suggestions

Warnings

Warnings do not block.

`PRA-1` Warning — Assert host staging cleanup after verification failures

Location: src/lib/actions/sandbox/sessions/export.test.ts:440
Category: tests
Problem: The missing-artifact tests assert remote staging cleanup and no publication, but they do not assert removal of the newly added host staging directory.
Impact: A regression in host staging cleanup could leave session exports, which can contain pasted secrets, in a local temporary directory after a failed download.
Recommendation: In the tar, directory, and Hermes missing-artifact tests, assert that the corresponding host staging directory is removed with `fs.rmSync(..., { recursive: true, force: true })`.
Verification: Inspect the missing-artifact tests near lines 440 and the Hermes verification-failure test, then confirm each checks the `rmSync` spy for its generated host staging directory.
Test coverage: Add assertions for host staging-directory removal after a zero-status download writes no artifact in tar, directory, and Hermes export paths.
Evidence: `removeHostStagingDir(hostStagingDir)` is newly called from `finally` in the tar, directory, and Hermes paths. Existing missing-artifact tests assert remote `rm -f` cleanup and no rename, but do not assert the `fs.rmSync` host cleanup call.

Workflow run details

This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge.

…ad-artifact-verify

Address review on #7371: verify each download against a fresh mkdtemp staging path and rename into place only after it passes, so a stale file from an earlier export cannot satisfy the exit-0/no-write check. Covers both the tar bundle and the per-file dir path (the tar path had the same exposure). Document the fresh-path precondition on assertDownloadedFile; correct the requireNonEmpty comment re: hermes; restore leaked fs spies in finally. Refs #7367 Signed-off-by: Dongni-Yang <dongniy@nvidia.com> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@test/sandbox-sessions-export-cli.test.ts`:
- Around line 174-180: Update the test around the downloadLines assertions to
verify staging-path targets for both sid-a.jsonl and sid-b.jsonl downloads, not
only downloadLines[0]. Preserve the existing checks that each published file
exists at its final outDir path, ensuring the full export flow validates staging
before publication for every directory download.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 636a4abb-b27d-4c66-b81e-23e3074f1212

📥 Commits

Reviewing files that changed from the base of the PR and between ca03e01 and 0f01fcc.

📒 Files selected for processing (4)

src/lib/actions/sandbox/sessions/download-verify.ts
src/lib/actions/sandbox/sessions/export.test.ts
src/lib/actions/sandbox/sessions/export.ts
test/sandbox-sessions-export-cli.test.ts

🚧 Files skipped from review as they are similar to previous changes (3)

src/lib/actions/sandbox/sessions/download-verify.ts
src/lib/actions/sandbox/sessions/export.ts
src/lib/actions/sandbox/sessions/export.test.ts

Fix the build-typecheck and codebase-growth-guardrails failures on the prior commit: type the statSync mock parameter (TS7006) and replace the if-based conditional mocks with a ternary + throwEnoent helper so the changed test files add no if statements. Also assert staging-path targets for both directory downloads (CodeRabbit), not just the first. Refs #7367 Signed-off-by: Dongni-Yang <dongniy@nvidia.com> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

apurvvkumaria

Sensitive-path review complete at exact head 8507e7c. The fresh 0700 staging directory, artifact verification, chmod, same-filesystem rename, and unconditional cleanup close the exit-0/no-artifact gap without introducing a concrete security or correctness regression. CI, E2E coordination, DCO, signatures, and review threads are clean. Non-blocking test-depth and wording refinements can be handled as fix-forward work.

Resolve to the rebase-equivalent tree after #7371 squash-merged: the branch payload is exactly the user-facing download probe/verification (download.ts, download-verify.ts, and their tests), byte-identical to the reviewed tip, applied on top of main. Refs #7367 Signed-off-by: Dongni-Yang <dongniy@nvidia.com> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

## Summary This PR adds the canonical dated release entry for NemoClaw v0.0.94 before the tag is cut. The entry reconciles all 26 commits since v0.0.93 and links each user-visible change to its owning documentation. ## Changes - Add `docs/changelog/2026-07-24.mdx` with the exact `## v0.0.94` heading, parser-safe SPDX comment, release summary, and detailed bullets. - Record sandbox restore and update behavior, onboarding and inference changes, network policy behavior, security evidence, Hermes build performance, DGX Station guidance, and E2E validation changes. - Preserve `docs/` as the source of truth without changing the AI-agent documentation routing skill. - Use [E2E run 30075443016](https://github.com/NVIDIA/NemoClaw/actions/runs/30075443016) for release QA evidence at exact tested SHA `04e6dfa883071dda9df429c66e73168e1a995cba`. ### Source summary - [#7461](#7461) -> `docs/changelog/2026-07-24.mdx`: Record the ownership-preserving Hermes image layer reduction and hosted timing comparison. - [#7460](#7460) -> `docs/changelog/2026-07-24.mdx`: Record removal of candidate Hermes swap setup from E2E validation. - [#7458](#7458) -> `docs/security/fern-5.80.1-dependency-review.md`, `docs/changelog/2026-07-24.mdx`: Record the reviewed Fern CLI update. - [#7457](#7457) -> `docs/changelog/2026-07-24.mdx`: Record periodic runner-pressure telemetry. - [#7455](#7455) -> `docs/changelog/2026-07-24.mdx`: Record non-blocking absent Fern previews. - [#7450](#7450) -> `docs/changelog/2026-07-24.mdx`: Record stable cancellation handling for live-test child processes. - [#7449](#7449) -> `docs/changelog/2026-07-24.mdx`: Record parallel plugin EXDEV coverage. - [#7448](#7448) -> `docs/changelog/2026-07-24.mdx`: Record isolated long-running E2E lanes. - [#7444](#7444) -> `docs/changelog/2026-07-24.mdx`: Record exact-head Hermes swap validation. - [#7437](#7437) -> `docs/manage-sandboxes/backup-restore.mdx`, `docs/changelog/2026-07-24.mdx`: Record gateway pairing and authenticated verification after cross-sandbox restore. - [#7436](#7436) -> `docs/manage-sandboxes/backup-restore.mdx`, `docs/reference/commands.mdx`, `docs/changelog/2026-07-24.mdx`: Record selected stale-state cleanup and Hermes virtual-environment access repair. - [#7385](#7385) -> `docs/network-policy/customize-network-policy.mdx`, `docs/changelog/2026-07-24.mdx`: Record the read-only agent-variant route check. - [#7371](#7371) -> `docs/changelog/2026-07-24.mdx`: Record host-artifact verification for session exports. - [#7359](#7359) -> `docs/changelog/2026-07-24.mdx`: Record platform validation for managed vLLM model overrides. - [#7356](#7356) -> `docs/changelog/2026-07-24.mdx`: Record token-shaped value redaction for `sandbox doctor --json`. - [#7354](#7354) -> `docs/security/advisory-early-warning.md`, `docs/changelog/2026-07-24.mdx`: Record advisory correlation and retained audit provenance. - [#7352](#7352) -> `docs/network-policy/customize-network-policy.mdx`, `docs/network-policy/integration-policy-examples.mdx`, `docs/reference/commands.mdx`, `docs/changelog/2026-07-24.mdx`: Record preset reapplication and bounded `tls: skip` guidance. - [#7345](#7345) -> `docs/security/openclaw-2026.6.10-dependency-review.md`, `docs/security/openclaw-2026.7.1-dependency-review.md`, `docs/changelog/2026-07-24.mdx`: Record reviewed npm audit exception enforcement. - [#7340](#7340) -> `docs/network-policy/customize-network-policy.mdx`, `docs/changelog/2026-07-24.mdx`: Record the repaired CLI-reference route. - [#7334](#7334) -> `docs/get-started/dgx-station-preparation.mdx`, `docs/changelog/2026-07-24.mdx`: Record the qualified OTA metadata fallback and narrowed override wording. - [#7322](#7322) -> `docs/changelog/2026-07-24.mdx`: Reconcile the gateway source tag added to plugin registration banners. - [#7284](#7284) -> `docs/manage-sandboxes/update-sandboxes.mdx`, `docs/changelog/2026-07-24.mdx`: Record read-only `upgrade-sandboxes --check` behavior and recorded-gateway selection. - [#7277](#7277) -> `docs/changelog/2026-07-24.mdx`: Reconcile deterministic gateway TCP refusal coverage. - [#7234](#7234) -> `docs/reference/troubleshooting.mdx`, `docs/changelog/2026-07-24.mdx`: Record preserved DGX Spark managed vLLM Express intent on resume. - [#7185](#7185) -> `docs/reference/troubleshooting.mdx`, `docs/changelog/2026-07-24.mdx`: Record IPv4 fallback DNS selection and exact resolver probing. - [#6820](#6820) -> `docs/reference/commands.mdx`, `docs/changelog/2026-07-24.mdx`: Record the versioned, redacted `--events=jsonl` onboarding stream. ## Type of Change - [ ] Code change (feature, bug fix, or refactor) - [ ] Code change with doc updates - [x] Doc only (prose changes, no code sample modifications) - [ ] Doc only (includes code sample changes) ## Quality Gates - [ ] Tests added or updated for changed behavior - [x] Existing tests cover changed behavior — justification: `npx vitest run test/changelog-docs.test.ts` passed 6/6 tests. - [ ] Tests not applicable — justification: - [x] Docs updated for user-facing behavior changes - [ ] Docs not applicable — justification: - [ ] Sensitive paths changed (security, policy, credentials, preflight, onboarding, inference, runner, sandbox, or messaging) - [ ] Sensitive-path review completed or maintainer-approved waiver recorded — reviewer/approval link/justification: - [ ] Non-success, skipped, or missing CI check accepted by maintainer — check name, approval link, and follow-up issue: ## Documentation Writer Review - [x] Documentation writer subagent reviewed the completed changes - Result: `docs-updated` - Evidence: `docs/changelog/2026-07-24.mdx`; the writing rules, documentation style, exact release range, skip terms, published routes, and product scope were reviewed; the changelog test passed 6/6; `npm run docs` passed with route checking OK, zero errors, and two existing warnings. - Agent: Codex Desktop   ## DGX Station Hardware Evidence - [ ] Tested on DGX Station - Tested commit: Not applicable - Station profile/scenario: Not applicable - Result: Not applicable - Supporting evidence: Not applicable. This PR does not change `scripts/prepare-dgx-station-host.sh`. ## Verification - [x] PR description includes a `Signed-off-by:` line and every commit appears as `Verified` in GitHub - [x] Normal `pre-commit`, `commit-msg`, and `pre-push` hooks passed, or `npm run check:diff` passed when hooks were skipped or unavailable - [x] Targeted behavior tests pass for the current change set, or tests are marked not applicable above — `npx vitest run test/changelog-docs.test.ts` passed 6/6 tests. - [ ] Applicable broad gate passed — `npm test` for broad runtime/test-harness changes; `npm run check` for repo-wide validation/coverage changes — command/result: Not applicable to the dated changelog entry. - [x] Quality Gates section completed with required justifications or waivers - [x] No secrets, API keys, or credentials committed - [ ] `npm run docs` builds without warnings (doc changes only). The build passed with zero errors and two existing Fern warnings. - [x] Doc pages follow the [style guide](https://github.com/NVIDIA/NemoClaw/blob/main/docs/CONTRIBUTING.md) (doc changes only) - [ ] New doc pages include SPDX header and frontmatter (new pages only). Native dated changelog entries use the required parser-safe MDX SPDX comment and no frontmatter. --- Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>  ## Summary by CodeRabbit * **Documentation** * Added the v0.0.94 release changelog. * Documented improvements to sandbox snapshot and restore behavior. * Added updates for gateway selection, policy comparisons, onboarding event output, and DGX recovery workflows. * Documented enhanced diagnostics redaction, npm audit provenance, image assembly performance, and validation stability improvements.  Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>

coderabbitai Bot reviewed Jul 22, 2026

View reviewed changes

Comment thread src/lib/actions/sandbox/sessions/download-verify.ts

Comment thread src/lib/actions/sandbox/sessions/download-verify.ts

Comment thread src/lib/actions/sandbox/sessions/export.test.ts Outdated

Comment thread src/lib/actions/sandbox/sessions/export.ts Outdated

Dongni-Yang mentioned this pull request Jul 22, 2026

[Linux][Security] openshell sandbox download returns exit code 0 when rejecting out-of-workspace paths #7367

Open

Dongni-Yang added the v0.0.92 label Jul 22, 2026

senthilr-nv added v0.0.93 and removed v0.0.92 labels Jul 22, 2026

Dongni-Yang and others added 2 commits July 23, 2026 06:43

Merge remote-tracking branch 'upstream/main' into dongniy/7367-downlo…

83c7234

…ad-artifact-verify

coderabbitai Bot reviewed Jul 23, 2026

View reviewed changes

Comment thread test/sandbox-sessions-export-cli.test.ts

Dongni-Yang mentioned this pull request Jul 23, 2026

fix(sandbox): verify the user-facing sandbox download wrote an artifact (#7367) #7416

Merged

23 tasks

wscurran added area: sandbox OpenShell sandbox lifecycle, runtime, config, or recovery area: security Security controls, permissions, secrets, or hardening bug-fix PR fixes a bug or regression labels Jul 23, 2026

prekshivyas assigned apurvvkumaria Jul 23, 2026

apurvvkumaria approved these changes Jul 23, 2026

View reviewed changes

apurvvkumaria merged commit 5379b13 into main Jul 23, 2026
81 checks passed

apurvvkumaria deleted the dongniy/7367-download-artifact-verify branch July 23, 2026 21:48

Dongni-Yang mentioned this pull request Jul 24, 2026

bug: sandbox download exits 0 when the source path is rejected (outside the sandbox workspace) NVIDIA/OpenShell#2456

Open

prekshivyas mentioned this pull request Jul 24, 2026

docs: add v0.0.94 release entry #7468

Merged

23 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(sandbox): verify session-export download wrote a file before recording a bundle (#7367)#7371

fix(sandbox): verify session-export download wrote a file before recording a bundle (#7367)#7371
apurvvkumaria merged 4 commits into
mainfrom
dongniy/7367-download-artifact-verify

Dongni-Yang commented Jul 22, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jul 22, 2026 •

edited

Loading

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

github-code-quality Bot commented Jul 22, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jul 22, 2026 •

edited

Loading

Warnings

`PRA-1` Warning — Assert host staging cleanup after verification failures

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

apurvvkumaria left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

Dongni-Yang commented Jul 22, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Related Issue

Changes

Type of Change

Quality Gates

Verification

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

github-code-quality Bot commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Overview

TypeScript / code-coverage/plugin

TypeScript / code-coverage/cli

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Review Advisor — Informational

Model lanes

E2E guidance

Warnings

PRA-1 Warning — Assert host staging cleanup after verification failures

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

apurvvkumaria left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Dongni-Yang commented Jul 22, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 22, 2026 •

edited

Loading

github-code-quality Bot commented Jul 22, 2026 •

edited

Loading

github-actions Bot commented Jul 22, 2026 •

edited

Loading

`PRA-1` Warning — Assert host staging cleanup after verification failures