Skip to content

fix(examples): add missing workspace fields to governance interceptor#2436

Merged
drew merged 1 commit into
NVIDIA:mainfrom
pavelanni:bug/fix-governance-interceptor-workspace-fields
Jul 23, 2026
Merged

fix(examples): add missing workspace fields to governance interceptor#2436
drew merged 1 commit into
NVIDIA:mainfrom
pavelanni:bug/fix-governance-interceptor-workspace-fields

Conversation

@pavelanni

Copy link
Copy Markdown
Contributor

Summary

The ListSandboxesRequest proto gained workspace and all_workspaces fields as part of the workspace feature, but the governance interceptor example was not updated, causing a compilation failure:

error[E0063]: missing fields `all_workspaces` and `workspace` in initializer of
              `openshell_core::proto::ListSandboxesRequest`

Sets all_workspaces: true so the interceptor's policy reload covers sandboxes across all workspaces.

Related Issue

None — found while running examples/governance-interceptor/smoke.sh on current main.

Changes

  • Added workspace: String::new() and all_workspaces: true to the ListSandboxesRequest initializer in the policy reload loop (src/main.rs)

Testing

  • cargo build --manifest-path examples/governance-interceptor/Cargo.toml compiles successfully
  • ./smoke.sh starts the gateway and interceptor without build errors

I have read the DCO document and I hereby sign the DCO.

The ListSandboxesRequest proto gained workspace and all_workspaces
fields in the workspace feature but the governance interceptor
example was not updated, causing a build failure.

Set all_workspaces to true so the interceptor's policy reload
covers sandboxes across all workspaces.

Assisted-By: Claude (Anthropic AI) <noreply@anthropic.com>
Signed-off-by: Pavel Anni <panni@redhat.com>
@copy-pr-bot

copy-pr-bot Bot commented Jul 23, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@drew

drew commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

/ok to test c7e3e18

@drew
drew enabled auto-merge July 23, 2026 01:06
@drew
drew added this pull request to the merge queue Jul 23, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Jul 23, 2026
@pavelanni

Copy link
Copy Markdown
Contributor Author

@drew This PR got pulled from the merge queue overnight with "removed this pull request from the merge queue due to no response for status checks" — looks like a timing race with the /ok to test gate (the queue attempt happened before CI was authorized to run). All checks are now green and the PR shows as mergeable. Could you re-add it to the merge queue when you have a moment? Thanks again for the review!

@drew
drew added this pull request to the merge queue Jul 23, 2026
Merged via the queue into NVIDIA:main with commit 75d2468 Jul 23, 2026
33 of 34 checks passed
@pavelanni
pavelanni deleted the bug/fix-governance-interceptor-workspace-fields branch July 23, 2026 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants