fix(examples): add missing workspace fields to governance interceptor#2436
Merged
drew merged 1 commit intoJul 23, 2026
Merged
Conversation
The ListSandboxesRequest proto gained workspace and all_workspaces fields in the workspace feature but the governance interceptor example was not updated, causing a build failure. Set all_workspaces to true so the interceptor's policy reload covers sandboxes across all workspaces. Assisted-By: Claude (Anthropic AI) <noreply@anthropic.com> Signed-off-by: Pavel Anni <panni@redhat.com>
pavelanni
requested review from
a team,
derekwaynecarr,
maxamillion and
mrunalp
as code owners
July 23, 2026 00:59
Collaborator
|
/ok to test c7e3e18 |
drew
approved these changes
Jul 23, 2026
drew
enabled auto-merge
July 23, 2026 01:06
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Jul 23, 2026
Contributor
Author
|
@drew This PR got pulled from the merge queue overnight with "removed this pull request from the merge queue due to no response for status checks" — looks like a timing race with the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
ListSandboxesRequestproto gainedworkspaceandall_workspacesfields as part of the workspace feature, but the governance interceptor example was not updated, causing a compilation failure:Sets
all_workspaces: trueso the interceptor's policy reload covers sandboxes across all workspaces.Related Issue
None — found while running
examples/governance-interceptor/smoke.shon current main.Changes
workspace: String::new()andall_workspaces: trueto theListSandboxesRequestinitializer in the policy reload loop (src/main.rs)Testing
cargo build --manifest-path examples/governance-interceptor/Cargo.tomlcompiles successfully./smoke.shstarts the gateway and interceptor without build errorsI have read the DCO document and I hereby sign the DCO.