Enable runtime resolution of CUDA header path for NVRTC - #3252
Merged
ptrendx merged 6 commits intoAug 11, 2026
Conversation
Collaborator
Author
|
/te-ci |
Collaborator
Author
|
Failing test is due to runner scheduling, should be unrelated to this |
Collaborator
Author
|
/te-ci |
fheinecke
marked this pull request as ready for review
August 3, 2026 22:03
Contributor
Greptile SummaryThe PR adds runtime discovery of CUDA headers for NVRTC while retaining the existing configured and build-time fallbacks.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains; the prior legacy and Python override issues are addressed by runtime-major-aware selection, and discovered paths are validated before use. Important Files Changed
Reviews (4): Last reviewed commit: "fix linter failure" | Re-trigger Greptile |
fheinecke
requested review from
KshitijLakhani,
ksivaman,
ptrendx and
timmoon10
August 4, 2026 20:02
ptrendx
reviewed
Aug 4, 2026
Signed-off-by: Fred Heinecke <fheinecke@nvidia.com>
for more information, see https://pre-commit.ci
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> Signed-off-by: fheinecke <23390735+fheinecke@users.noreply.github.com>
… of site-packages directory Signed-off-by: Fred Heinecke <fheinecke@nvidia.com>
Signed-off-by: Fred Heinecke <fheinecke@nvidia.com>
Signed-off-by: Fred Heinecke <fheinecke@nvidia.com>
fheinecke
force-pushed
the
fred/nvrtc-runtime-header-resolution-1
branch
from
August 7, 2026 17:02
d11bc9e to
c443baa
Compare
ptrendx
approved these changes
Aug 11, 2026
Member
|
/te-ci |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
NVRTC relies on having CUDA toolkit headers available at runtime for JIT compilation. The following directories are searched:
${NVTE_CUDA_INCLUDE_DIR}${CUDA_HOME}${CUDA_DIR}/usr/local/cudaThe build-time path may coincidentally line up with the runtime path, but may be incorrect when building TE on another machine or environment, or when building TE with build isolation enabled. This enables searching site-packages at runtime for the headers, allowing them to be resolved in more environments. If checked paths don't exist, then this will fall back to the existing behavior.
Type of change
Changes
Please list the changes introduced in this PR:
Checklist: