[Pytorch] Fix swizzle scale output shape in variable shape case - #3344
Merged
Conversation
Signed-off-by: YangFei1990 <feiw@nvidia.com>
for more information, see https://pre-commit.ci
Contributor
Greptile SummaryThe PR corrects grouped MXFP8 swizzle output allocation for variable-shaped tensors by preserving the existing scale-buffer shape.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Reviews (3): Last reviewed commit: "Merge branch 'main' into fix_swizzle_out..." | Re-trigger Greptile |
Collaborator
Author
|
/te-ci L1 pytorch |
Collaborator
Author
|
/te-ci L1 pytorch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The swizzle scale output shape computation does not respect the first/last dim settings, which still always assume even split. This PR adds support for the variable shape case.
Fixes # (issue)
Type of change
Checklist: