Fix a shadow warning in thrust's execute_with_dependencies.h - #334
Merged
Conversation
hageboeck
requested review from
miscco and
wmaxey
and removed request for
a team
August 15, 2023 13:16
|
Pull requests from external contributors require approval from a |
Contributor
|
/ok to test |
miscco
approved these changes
Aug 15, 2023
Contributor
|
Thanks a lot for the contribution 🎉 |
Contributor
Author
|
Now the issue is also in this repo: |
Contributor
|
@jarmak-nv Shouldnt this PR get someone assigned? EDIT: Now that I write it I see that Wesley was also added |
jrhemstad
approved these changes
Aug 15, 2023
Contributor
|
@wmaxey I believe we do not want this also backported to 2.2 It is only a warning after all? |
Contributor
|
Thanks a lot for the contribution 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[skip-tests]
Fix NVIDIA/thrust#1980
Fix #335
Moved to here from NVIDIA/thrust#1981 (comment)
Checklist