Skip to content

Support cooperative launch#676

Merged
leofang merged 6 commits into
NVIDIA:mainfrom
leofang:coop_launch
Jun 6, 2025
Merged

Support cooperative launch#676
leofang merged 6 commits into
NVIDIA:mainfrom
leofang:coop_launch

Conversation

@leofang

@leofang leofang commented Jun 3, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Description

Part of #496.

Merge after #648.

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@leofang leofang self-assigned this Jun 3, 2025
@copy-pr-bot

copy-pr-bot Bot commented Jun 3, 2025

Copy link
Copy Markdown
Contributor

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@leofang leofang added P0 High priority - Must do! feature New feature or request cuda.core Everything related to the cuda.core module blocked This task is currently blocked by other tasks labels Jun 3, 2025
@leofang leofang added this to the cuda.core beta 4 milestone Jun 3, 2025
@leofang

leofang commented Jun 3, 2025

Copy link
Copy Markdown
Member Author

/ok to test 3bdf609

@leofang leofang requested a review from oleksandr-pavlyk June 3, 2025 05:34
@github-actions

github-actions Bot commented Jun 3, 2025

Copy link
Copy Markdown
Doc Preview CI

🚀 View preview at
https://nvidia.github.io/cuda-python/pr-preview/pr-676/

https://nvidia.github.io/cuda-python/pr-preview/pr-676/cuda-core/

https://nvidia.github.io/cuda-python/pr-preview/pr-676/cuda-bindings/


Preview will be ready when the GitHub Pages deployment is complete.

@leofang leofang removed the blocked This task is currently blocked by other tasks label Jun 4, 2025
@leofang leofang marked this pull request as ready for review June 4, 2025 03:36
@leofang

leofang commented Jun 4, 2025

Copy link
Copy Markdown
Member Author

/ok to test b717e53

leofang
leofang commented Jun 4, 2025
View reviewed changes
Comment thread cuda_core/tests/test_launcher.py
kkraus14
kkraus14 reviewed Jun 4, 2025
View reviewed changes
Comment thread cuda_core/cuda/core/experimental/_launch_config.py
Comment thread cuda_core/cuda/core/experimental/_launcher.py Outdated
Comment thread cuda_core/tests/test_launcher.py Outdated
@leofang

leofang commented Jun 6, 2025

Copy link
Copy Markdown
Member Author

/ok to test 08e5592

@leofang

leofang commented Jun 6, 2025

Copy link
Copy Markdown
Member Author

/ok to test 447c40d

kkraus14
kkraus14 approved these changes Jun 6, 2025
View reviewed changes
Comment thread cuda_core/cuda/core/experimental/_utils/cuda_utils.py
@leofang leofang mentioned this pull request Jun 6, 2025
Open
@leofang leofang merged commit 430e890 into NVIDIA:main Jun 6, 2025
53 checks passed
@leofang leofang deleted the coop_launch branch June 6, 2025 13:37
@leofang

leofang commented Jun 6, 2025

Copy link
Copy Markdown
Member Author

Thanks, Keith/Piotr!

@leofang leofang mentioned this pull request Jun 6, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kkraus14 kkraus14 kkraus14 approved these changes

@oleksandr-pavlyk oleksandr-pavlyk Awaiting requested review from oleksandr-pavlyk

+1 more reviewer

@pciolkosz pciolkosz pciolkosz left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@leofang leofang

Labels

cuda.core Everything related to the cuda.core module feature New feature or request P0 High priority - Must do!

Projects

None yet

Milestone

cuda.core beta 4

Development

Successfully merging this pull request may close these issues.

3 participants

@leofang @kkraus14 @pciolkosz