Remove numpy scalar from stream name representation for neuralynx - #1679
Merged
zm711 merged 1 commit intoApr 3, 2025
Merged
Conversation
zm711
approved these changes
Apr 3, 2025
zm711
left a comment
zm711
left a comment
Contributor
There was a problem hiding this comment.
Just for full explanation in the PR this is due to the fact that numpy has changed how it represents strs such that they appear as np.str_ which are much harder to parse. Converting to a python values (floats or ints) will allow the header representation of this data to work regardless of the version of numpy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of #1678 but does not solve it completly.