NeuroNexusIO: Add in appropriate streams to go with buffer API - #1711
Merged
Conversation
zm711
commented
May 14, 2025
Contributor
|
OK for me. |
samuelgarcia
approved these changes
Jul 4, 2025
Contributor
Author
good idea. Done. |
Contributor
|
@zm711 SpikeInterface tests are failing: https://github.com/SpikeInterface/spikeinterface/actions/runs/16075631831/job/45370080806?pr=4025 Since you know what's going on, could you update the test_neoextractors NeuroNexus tests too? :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I first implemented this before the buffer api and since this is one buffer for all streams we left them all packed together. Now that we have the buffer api we should divide these streams into
ephys data (called analog in allego docs)
din
dout
aux
No rush on this so we can wait until we figure out plexon2 tests.