OpenEphysBinary: do not split ADC streams for OneBox - #1753
Conversation
|
@alejoe91, while we wait for the user to test this could you add to the docstring or comment above what the OneBox should look like as far as we know? So it is a three dir system in the main expt dir? Or whatever. |
|
Are we still waiting for data on this one or should I move forward with the review? I think Alessio is on vacation so feel free to reply once you are back. |
|
To me it looks like we have a spikeglx version of data but not an openephys version. So I would prefer
But I think it is fine if you want to review @h-mayorquin. If you have an example at neuroconv you can still test the function without the official test. |
|
Someone shared data with us. Once Alessio is back I can take a look. I just did not understand above if a user already promised they would give us some data. |
Hi guys, here is the issue with the data (somehow I forgot to link it in the first place!): SpikeInterface/spikeinterface#4083 |
|
@zm711 @h-mayorquin can any of you upload the data on GIN? I'm running into the usual git-annex version issue... The data from @jialeren2024 is here: SpikeInterface/spikeinterface#4083 (comment) |
|
That's great, merged the data. The data that I have is only one box so it will not be useful to test the error. If I read the PR from gin well, the data that @alejoe91 provided does contain both neural and analog one box acquisition data which is what we need. |
|
Seems like the metadata is being misread? Based on the error in the test suite? |
|
@apdavison any word on ebrains? It seems like docs are failing because we are timing out with our connection to download the ebrains dataset? |
|
I'll merge after tests pass! |
h-mayorquin
left a comment
h-mayorquin
left a comment
There was a problem hiding this comment.
JUst one question that I did not send by mistake yesterday.
| self.get_local_path("openephysbinary/v0.6.x_neuropixels_with_sync"), load_sync_channel=True | ||
| ) | ||
| rawio_with_sync.parse_header() | ||
| with self.assertWarns(DeprecationWarning): |
There was a problem hiding this comment.
What deprecation warning is this asserting for?
Could we use https://docs.python.org/3/library/unittest.html#unittest.TestCase.assertWarnsRegex
to match the message
3 participants
Fixes #1752