Repository navigation
Show nginx config errors for proxy hosts - #5916
PrassanthVG wants to merge 1 commit into
Conversation
When nginx rejected a proxy host config (e.g. unresolvable custom location host) the host was taken offline silently: create returned stale meta, the status column only reflected the enabled flag and the save showed success. Return the fresh meta, show Offline with the nginx error in the table, and show the error on save. Fixes NginxProxyManager#5883
|
| cell: (info: any) => { | ||
| return <TrueFalseFormatter value={info.getValue()} trueLabel="online" falseLabel="offline" />; | ||
| return ( | ||
| <span title={info.row.original.meta?.nginxErr || undefined}> |
There was a problem hiding this comment.
Error only available on hover The nginx error is placed in a
title tooltip on a span that cannot receive keyboard focus. After the save dialog closes and its notification disappears, keyboard and touch users cannot reliably read why the host is offline. Please make the error accessible from the table without requiring a mouse.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
|
CI is failing in the cypress test suite: |
When nginx rejected a proxy host config (e.g. unresolvable custom location host) the host was taken offline silently: create returned stale meta, the status column only reflected the enabled flag and the save showed success. Return the fresh meta, show Offline with the nginx error in the table, and show the error on save.
Fixes #5883
Why
Fixes #5883. When nginx rejects a proxy host config (e.g. a custom location with an unresolvable host), the host is taken offline but the UI gave no indication:
enabledNow create returns the fresh meta, the Status column shows Offline (with the nginx error on hover), and saving shows the nginx error.
Type of Change
AI Usage
Type of Change
AI Usage