Repository navigation
setup: stop on EOF instead of accepting prompt defaults - #398
Closed
Bortlesboat wants to merge 1 commit into
Closed
Bortlesboat wants to merge 1 commit into
Bortlesboat wants to merge 1 commit into
Conversation
Owner
|
Released in 0.1.33 as is. Merged under your name (GitHub doesn't show it as merged because it went in by hand). Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setup now exits with a clear message when a prompt reaches EOF, preventing closed stdin from accepting the
ydefault for Visual Studio Build Tools and CUDA installation. This applies to everyask()prompt; pressing Enter or supplying a valid piped answer still works, and--yesstill accepts each prompt's recommended default.Validated on Windows with Python 3.12.10: the new regression suite produces four failures before the fix, including attempts to reach the Windows and Linux installer commands; all 68 tests below pass afterward. Five child-process checks also pass with closed or piped stdin, and Ruff reports no issues in the changed files.
Hardware discovery and installer execution are mocked; no system packages or models were downloaded or installed. The shard tests emit ResourceWarnings in unchanged
tools/strata_pack.py.Fixes #393.