Repository navigation
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and result
The Docker build context omits
tools/dsv41, even thoughpackaging/package_terminal.pyrequires installer scripts from that directory. As reported in #4082, this causes the image build to stop withinstaller tool missing: tools/dsv41/tune.py.This change stages
tools/dsv41in the Docker build context, so the installer scripts are available when the Terminal package is assembled.Related discussion
Fixes #4082: #4082
Approach
Add
tools/dsv41to the source paths copied bydocker/build.sh. Extend the existing tests to verify that installer scripts declared inINSTALLER_SCRIPTSare covered by those paths, and thattune.pyis present in the assembled context.Validation
Passed:
python -m unittest tests.terminal.test_docker_files tests.terminal.test_docker_fetch— 22 tests passed on Linux at commit318c5fb3.sh -n docker/build.sh— passed.git diff --check origin/main...HEAD— passed.Failed:
Not run:
Limits
This fixes the missing DSV41 installer scripts in the Docker build context. It does not change the engine package or add GPU architecture support.