Skip to content

[Other] include dsv41 installer scripts in Docker build context - #4140

Open
LawiK974 wants to merge 1 commit into
Niko1221:mainfrom
LawiK974:fix/docker-installer-tools-context
Open

LawiK974 wants to merge 1 commit into
Niko1221:mainfrom
LawiK974:fix/docker-installer-tools-context

Conversation

@LawiK974

Copy link
Copy Markdown

Problem and result

The Docker build context omits tools/dsv41, even though packaging/package_terminal.py requires installer scripts from that directory. As reported in #4082, this causes the image build to stop with installer tool missing: tools/dsv41/tune.py.

This change stages tools/dsv41 in the Docker build context, so the installer scripts are available when the Terminal package is assembled.

Related discussion

Fixes #4082: #4082

Approach

Add tools/dsv41 to the source paths copied by docker/build.sh. Extend the existing tests to verify that installer scripts declared in INSTALLER_SCRIPTS are covered by those paths, and that tune.py is present in the assembled context.

Validation

Passed:

  • python -m unittest tests.terminal.test_docker_files tests.terminal.test_docker_fetch — 22 tests passed on Linux at commit 318c5fb3.
  • sh -n docker/build.sh — passed.
  • git diff --check origin/main...HEAD — passed.
  • The GitHub Actions Docker image build was tested from the fork. The image repository had to be overridden because the workflow targeted the upstream GHCR repository; fork-specific image destination handling is in separate commit, not in this installer-tools-only change.

Failed:

  • None observed on this branch.

Not run:

  • No GPU smoke test was run; the change only affects files included in the Docker build context.

Limits

This fixes the missing DSV41 installer scripts in the Docker build context. It does not change the engine package or add GPU architecture support.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Other] docker/build.sh leaves out tools/dsv41/*.py, so the image build stops at "installer tool missing: tools/dsv41/tune.py"

1 participant