Skip to content

fix: make the CUDA language link the shared runtime (Windows sm_70 LNK1169, #585) #717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
noahark wants to merge 1 commit into from
Closed

fix: make the CUDA language link the shared runtime (Windows sm_70 LNK1169, #585) #717

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,14 @@ if(STRATA_BUILD_CONVERSATION_TESTS)
endif()

if(STRATA_ENABLE_CUDA)
# #585: the CUDA language links the runtime per CMAKE_CUDA_RUNTIME_LIBRARY, whose default is "Static"
# (cudart_static.lib), while the targets below link the imported CUDA::cudart explicitly (the dynamic
# import library). Both end up on the link line; MSVC rejects the duplicated runtime symbols
# (LNK2005/LNK1169) - seen on a Windows sm_70 source build - while GNU ld tolerates them, so Linux
# never noticed. "Shared" makes the language rule agree with CUDA::cudart; an explicit -D keeps winning.
if(NOT DEFINED CMAKE_CUDA_RUNTIME_LIBRARY)
set(CMAKE_CUDA_RUNTIME_LIBRARY Shared)
endif()
enable_language(CUDA)
# `enable_language(CUDA)` gives the .cu compile rules but NOT the imported targets, so `CUDA::cudart` has to
# be brought in explicitly for the host-side tests that call cudaMalloc themselves.
Expand Down