Repository navigation
Conversation
Niko1221
added a commit
that referenced
this pull request
Oct 6, 2026
STRATA_ARENA_RELEASE already exists and means the opposite (=0 keeps the experts a GPU holds, generate.cpp), so the opt-in is renamed in the engine, the tests, DETAILS.md and the bench folder. The working-set assert in file_expert_source_test reports, not fails, a trimmed page that Windows maps straight back with the switch on. The bench folder keeps the README and the two scripts (the raw export and the harness self-tests are dropped). Co-authored-by: jordicor <59069878+jordicor@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Owner
|
Merged in 0.1.40 with one change: the switch is STRATA_FILE_RELEASE=1, because STRATA_ARENA_RELEASE already exists and means the opposite (=0 keeps the experts a GPU holds). Default off. The bench folder keeps the README and the two scripts. |
Niko1221
added a commit
that referenced
this pull request
Oct 6, 2026
STRATA_ARENA_RELEASE already exists and means the opposite (=0 keeps the experts a GPU holds, generate.cpp), so the opt-in is renamed in the engine, the tests, DETAILS.md and the bench folder. The working-set assert in file_expert_source_test reports, not fails, a trimmed page that Windows maps straight back with the switch on. The bench folder keeps the README and the two scripts (the raw export and the harness self-tests are dropped). Co-authored-by: jordicor <59069878+jordicor@users.noreply.github.com>
anon761
pushed a commit
to anon761/Strata-upstream
that referenced
this pull request
Oct 6, 2026
…221#818) STRATA_ARENA_RELEASE already exists and means the opposite (=0 keeps the experts a GPU holds, generate.cpp), so the opt-in is renamed in the engine, the tests, DETAILS.md and the bench folder. The working-set assert in file_expert_source_test reports, not fails, a trimmed page that Windows maps straight back with the switch on. The bench folder keeps the README and the two scripts (the raw export and the harness self-tests are dropped). Co-authored-by: jordicor <59069878+jordicor@users.noreply.github.com>
sskver
pushed a commit
to sskver/Strata
that referenced
this pull request
Oct 7, 2026
…221#818) STRATA_ARENA_RELEASE already exists and means the opposite (=0 keeps the experts a GPU holds, generate.cpp), so the opt-in is renamed in the engine, the tests, DETAILS.md and the bench folder. The working-set assert in file_expert_source_test reports, not fails, a trimmed page that Windows maps straight back with the switch on. The bench folder keeps the README and the two scripts (the raw export and the harness self-tests are dropped). Co-authored-by: jordicor <59069878+jordicor@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a 32 GB Windows 11 laptop with an RTX 4080 Laptop and a Thunderbolt RTX 3090, file-backed expert pages remained in the engine's working set after their GPU copies. With IQ2_XS and the existing layer split, available RAM stayed near 0.5 GiB during the measured workload.
This adds opt-in Windows mapped-page release via
STRATA_ARENA_RELEASE=1. Unset or0preserves the current behavior.FileExpertSource::release()forexperts.binand direct GGUF file views using Windows working-set trimming. Preserve shared boundary pages and never trim private/pinned staging buffers.Measured result
The same prototype executable was run with explicit release OFF and ON: one warmup and three fresh requests each at 1K, 4K and 16K prompt tokens, 256 output tokens, context 32768, int8 KV, MTP,
--mmap-experts --layer-split 12 --trim-stage-weights.Prefill throughput was 3.7-4.4% lower. This improves physical-memory availability on this machine; it does not reduce commit, demonstrate fewer SSD reads, or establish a general speed improvement. Runs were sequential, the OS file cache was retained, and generated code-explanation responses differed. The submitted patch defaults to OFF; the measured prototype defaulted to ON, but both benchmark arms set the switch explicitly.
Full configuration, individual timings, hashes, reproduction commands and limitations: measurement report.
Validation
file_expert_source_testandexpert_layout_testpass in separate processes with the switch unset,0, and1: page alignment and working-set behavior, unchanged bytes after repeated reads, invalid indices, closed sources, and three GGUF roles across two shards.The prototype also completed 30 functional requests without runtime errors. All 24 objective responses/statuses matched the official engine at the same placement: 21 passes and three unchanged Markdown-fenced-JSON failures; six prose responses were unscored. These limited checks do not prove general output parity.
Related prior work: #467 and #640. The existing multi-GPU implementation is reused; this PR contributes Windows mapped-page release.