Add regression test for contentFiles include with leading separator - #7600
Merged
Merged
Conversation
nkolev92
approved these changes
Jul 28, 2026
This was referenced Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: https://github.com/NuGet/Client.Engineering/issues/3901
Description
A customer reported that in VS 18.8, a
contentFilesentry with a leading separator in theincludepath was silently ignored when restoring in Visual Studio.e.g.
\any\net10.0\data\*had the configuredbuildActionandcopyToOutputdropped in VS, whiledotnet buildworked correctly.In VS 18.9, this was already fixed, but no test was added for the scenario.
Root cause
The content-file globbing introduced in #7338 built match paths as MatcherRoot ("ROOT/" ) + the relative path. When an include starts with a separator, this produced a malformed path (
ROOT/\any) thatMicrosoft.Extensions.FileSystemGlobbingfailed to match. The entry was dropped and its build action fell back to the default (Compile) silently with no error.The bug was already fixed by #7405, which reworked matching to use InMemoryDirectoryInfo + Matcher.Execute . However, no test ever covered this scenario, so the fix is unguarded against regression.
What this adds
This test covers leading forward-slash, leading backslash, interior-backslash, and canonical include forms. Each asserts the resolved build action is
None(the authored value) rather than the defaultCompile, proving the glob matched.Verification
Test passes on dev (has fix from #7405).
Test FAILs on
release/7.8.xfor the leading-separator cases (Expected: None, Actual: Compile) and this confirms it reproduces the customer regression.PR Checklist
Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.