Skip to content

Add additionalProperties to Schema Object Documentation #285

Closed

Description

@Smolations

There is an example under the Schema Object definition which uses the "additionalProperties" key, but it is not specified as a possible key in the above spec.

Activity

  1. added a commit that references this issue on Mar 4, 2015
    989544c
  2. analogue commented on Mar 11, 2015

    @analogue

    So all that is left here is updating the docs in 2.0.md?

  3. webron commented on Mar 11, 2015

    @webron
    Member

    @analogue - you can see the link to the commit in the issue. It'll be available once I merge the fixes with master.

  4. analogue commented on Mar 11, 2015

    @analogue

    @webron As I understand it, there are two things that need to done to resolve this issue.

    • Update the jsonschema for the Swagger Specificiation to support additionalProperties on object types. This appears in commit 989544c
    • Update the list of properties in https://github.com/swagger-api/swagger-spec/blob/master/versions/2.0.md#schema-object to include additionalProperties. This item is the reason for my original question. Without this update, it is not apparent from reading the spec that additionalProperties is even supported (except for the usage in an example which begs the question "Is this an error in the spec or an error in the example?").
  5. webron commented on Mar 11, 2015

    @webron
    Member

    Oh wow, I was sure I added that as well already. Thanks for bring it up, will be available in the fixes branch shortly.

  6. added a commit that references this issue on Mar 11, 2015
    e991b60
  7. webron commented on Mar 11, 2015

    @webron
    Member

    Done.

  8. Smolations commented on Mar 16, 2015

    @Smolations
    Author

    Thanks everyone! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions