REGCA Implementation#415
Conversation
pelesh
left a comment
There was a problem hiding this comment.
Blocking this PR until Jacobian implementation in PhasorDynamics is refactored to eliminate deprecated Matrix_COO object.
b81d2a6 to
78d4d41
Compare
03b329f to
f4d4e70
Compare
ada69bc to
89aac1e
Compare
89aac1e to
315004e
Compare
29e4c35 to
9b5681f
Compare
|
This has been rebased and cleaned for consistancy |
77f83d1 to
f2b5872
Compare
f2b5872 to
ab0a8f2
Compare
ab0a8f2 to
b3457ec
Compare
098b762 to
900594d
Compare
1497e8d to
b4afc84
Compare
nkoukpaizan
left a comment
There was a problem hiding this comment.
I think the implementation needs some cleanup, particularly the verification of parameters and related branching. More specific comments below.
b4afc84 to
f22d21a
Compare
|
@nkoukpaizan Thank you so much for the detailed review!! I will address all concerns, and once I am done, I will make sure the other models are consistent with this one since it's the first new model in a while. Very very appreciated. do not hold back on critiques I want all the new models consistent |
|
@nkoukpaizan okay I spent a while cleaning this up so I can align the others with this style. the tests are much better. I think we need some more |
Description
Adds the REGCA renewable generator/converter model to PhasorDynamics, including system-model JSON parsing, signal wiring for optional current-command inputs, monitor support, and Enzyme/dependency-tracking Jacobian coverage.
Proposed changes
Converter/REGCAmodel, data type, CMakeRegcaintoComponentLibrary,SystemModelData,SystemModel, and JSON parsing.Checklist
-Wall -Wpedantic -Wconversion -Wextra.Further comments
Won't add this to any
examplesuntil I haveREECAsince they go together in all cases we have in PowerWorld