Repository navigation
chore(sse): wire the test suite into the Makefile - #244
Merged
Merged
Conversation
sse had no Makefile target, so make test silently skipped its 67 tests even though CI's bare pytest ran them. Add test-sse and benchmark-sse, list both in the aggregates, and pass -rs so skip reasons are visible. Fixes #242
Oaklight
force-pushed
the
feat/sse-tooling
branch
from
October 23, 2026 04:45
d72b0d4 to
cbd5200
Compare
This was referenced Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
CI runs bare
pytest, so the SSE suite is covered there — but the documentedlocal workflow is
make test, andssewas never added to the Makefile. Acontributor following the project docs silently skipped 67 tests. The two
modules SSE composes with (httpclient for transport, httpserver for serving)
also never mentioned it, so the pairing was only discoverable by reading the
module index.
What
test-sserunstest_sse_correctness.pyandtest_sse_inject.pywith-rs;benchmark-sseruns the httpx-ssecomparison. Both are in the
.PHONYlist, thetest/benchmarkaggregates, and
make help.EventSource(r.iter_lines())fortext/event-streaminstead of leavingline-splitting to the reader.
encode_event()/encode_comment()and explains why hand-writingdata: ...\n\nbreaks onpayloads containing a blank line.
ssedescription now mentions the event encoder,matching the regenerated
modules/index.mdon both docs branches.Verification
make test-sse→ 67 passed.make benchmark-sse→ 6 passed.make helplists both targets.The docs live on the
docs_en/docs_zhworktree branches per projectconvention and are pushed separately.
Fixes #242