review fixes for #598: Scalar SRI pin, buy-x402 guard order, 402 token sanitization#599
Merged
Merged
Conversation
The /api OpenAPI reference is served over the public tunnel and pulls the @scalar/api-reference bundle from jsdelivr. The integrity hash was left empty in phase 1, so the browser executed whatever the CDN returned, unverified. Populate scalarBundleSRI with the sha384 of the pinned 1.34.0 bundle so a tampered CDN response is blocked. Comment updated to stress the hash must be re-derived in lockstep with every scalarBundleVersion bump.
…arning The 'paid/<model> not selectable in LiteLLM' guard ran *after* the no-auto-refill WARNING. A model that LiteLLM would refuse still printed a scary 'every chat turn fails when the pool empties' warning describing a primary-model failure mode that cannot occur when the default was never switched. Reorder so we refuse first and only warn when we are actually about to adopt the model.
…e commands spec.model.name and metadata.name flow from the ServiceOffer CR into copy-pasteable 'obol buy inference ...' commands rendered on the public 402 page. A hostile or fat-fingered offer could smuggle shell metacharacters into a command a reader might paste. Add sanitizeDisplayToken at the render boundary: CR-sourced tokens must match the model-id/k8s-name charset (^[A-Za-z0-9._:/-]+$) or collapse to the existing safe placeholder. Real ids like qwen3.5:9b and anthropic/claude-3-5-sonnet-latest pass through unchanged.
This was referenced Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review fixes for the #593-plus integration branch
Targets
integration/pr-593-plus. Addresses the three findings from the multi-agent review of the consolidated diff. No blockers were found; these are the hardening follow-ups.1.
security(x402)— SRI-pin the Scalar bundle on the public/apipage (MED)internal/serviceoffercontroller/scalar_html.goThe
/apiOpenAPI reference is served over the public tunnel and pulls@scalar/api-reference@1.34.0from jsDelivr.scalarBundleSRIwas empty, so the browser executed whatever the CDN returned, unverified. Populated with thesha384of the pinned bundle.2.
fix(buy-x402)— guard before warning (MED)internal/embed/skills/buy-x402/scripts/buy.pyThe
paid/<model>existence guard ran after the no-auto-refill WARNING, so a model LiteLLM would refuse still printed a "your chat will brick" warning describing a failure mode that can't happen when the default is never switched. Reordered: refuse first, warn only when actually adopting.3.
security(x402)— sanitize ServiceOffer-sourced tokens in copy-paste commands (LOW)internal/x402/paymentrequired.go(+ tests)spec.model.name/metadata.nameflow from the CR into copy-pasteableobol buy inference …commands on the public 402 page. AddedsanitizeDisplayTokenat the render boundary — CR tokens must match^[A-Za-z0-9._:/-]+$or collapse to the existing safe placeholder. Real ids (qwen3.5:9b,anthropic/claude-3-5-sonnet-latest) pass through unchanged; shell metacharacters cannot.Verification
python3 -m py_compile buy.pyOKgo build ./...,go vet,gofmt -lcleanTestSanitizeDisplayToken+TestInferenceCopy_StripsShellMetacharsFromCommand