fix(serviceoffer): split inFlightReq and rateLimit middlewares#759
Merged
Conversation
…iddlewares Combining --max-in-flight and --rps produced one Middleware CR with both types; Traefik rejected it while the offer still reported Ready. Emit one CR per type, attach both ExtensionRefs, and delete the legacy -limits CR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--max-in-flight+--rpsgenerated a single Traefik Middleware with bothinFlightReqandrateLimit. Traefik rejects that combination, but the ServiceOffer still reached Ready.Now each limit is its own Middleware CR (+ ExtensionRef). Legacy
so-*-limitsCRs are deleted on reconcile.Test plan
go test ./internal/serviceoffercontroller/ -run TestBuildLimitsobol sell http … --max-in-flight 4 --rps 10and confirm two Middleware CRs accepted by TraefikPart of v0.14.0-rc0 hackathon bugfix train.