fix(sell): enable offers after CLI ERC-8004 register#761
Merged
bussyjd merged 1 commit intoJul 15, 2026
Conversation
obol sell register left ServiceOffers created with --no-register stuck at registration.enabled=false / Registered=Disabled while the on-chain AgentIdentity already had an agentId. After a successful register, patch those offers enabled=true and treat a known agentId as Registered=True even when RegistrationRequest phase is empty.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
obol sell register, patch every ServiceOffer withregistration.enabled=false→trueso post-hoc registration activates existing--no-registeroffers.Registered=Trueeven if phase is empty — fixes non-owner offers stuck Pending and status/checkmarks disagreeing.Test plan
go test ./internal/serviceoffercontroller/ -run TestApplySharedgo test ./cmd/obol/ -run TestSellPart of v0.14.0-rc0 hackathon bugfix train.