Implemented closest (ray, point) - #83
Open
AlchemistReturns wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closest(ray, point)(line 888) was a stub that just returned the input point unconditionally, never actually projecting onto the ray. This implements it properly: projects the point onto the ray's direction, clamped to t ≥ 0 so points "behind" the ray's origin correctly return the origin itself instead of an out-of-bounds result.Testing:
Verified with a standalone test harness against known cases (point ahead of ray, point behind origin, point already on the ray).
This is my first open source contribution and I'd like to keep contributing. Picked this from the gaps listed for the project, happy to pick up more of the closest(...) stubs if this one looks good.