Add Panther Plugin Framework - #1
Draft
adammcdonagh wants to merge 6 commits into
Draft
adammcdonagh wants to merge 6 commits into
adammcdonagh wants to merge 6 commits into
Conversation
First attempt at adding plugin framework and supporting document updates Signed-off-by: Adam McDonagh <adam@elitemonkey.net>
Signed-off-by: Adam McDonagh <adam@elitemonkey.net>
Signed-off-by: Adam McDonagh <adam@elitemonkey.net>
Signed-off-by: Adam McDonagh <adam@elitemonkey.net>
Signed-off-by: Adam McDonagh <adam@elitemonkey.net>
Signed-off-by: Adam McDonagh <adam@elitemonkey.net>
adammcdonagh
force-pushed
the
feat/plugin-framework
branch
from
August 31, 2026 23:56
c94b0da to
fff4163
Compare
Collaborator
|
Hi Adam, There are a few suggestions and alterations that would make merging this easier, generally along the lines of splitting it up into smaller reviewable chunks:
Things we'd decline right now:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft PR looking for any comments before submitting.
The primary purpose of this PR is to add a mechanism to extend Panther with custom plugins that impact the core functionality. This includes adding SSO, editing the alert schema with custom columns, injecting actions into the insert/update/delete events.
SSO has been tested and validated with Google SAML auth - See https://github.com/adammcdonagh/panther-sso-saml
Example plugin for adding custom columns to the schema can be found here - https://github.com/adammcdonagh/panther-custom-columns
Changes
applyConsole(...).applyConsoleAuth(...), runs after Express creation so plugins can register Passport strategies and auth routes. (currently untested)POST /loginfalls through when local auth is disabled so a plugin can own that path. (currently untested)authsection withlocal.enabledandprovidersdefaults.pluginssection.Field.extend(...)lets plugins add field definitions/default visible fields.applyServer(...)before alert schema registration.PANTHER_PLUGIN_INSTALLandPANTHER_PLUGIN_DIR.