Repository navigation
fix(rewards): define domain-bound v2 claim signatures - #630
Draft
raymondjacobson wants to merge 1 commit into
Draft
raymondjacobson wants to merge 1 commit into
raymondjacobson wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a V2 reward-claim codec that binds the deployment domain, program, reward manager, mint, core reward record, recipient, raw amount, oracle, nonce, expiry and revocation epoch. Oracle and validator roles have distinct signed bytes, and oracle signature verification requires the exact declared oracle key.
This is a draft protocol component. It is not connected to a signing endpoint and does not re-enable programmable attestations. Trusted reward/pool lookup, current on-chain policy validation, eligibility checks and the API/SDK migration still need implementation before activation. The matching Solana verifier must be reviewed and deployed as part of a coordinated transition that invalidates legacy settlement.
Validation:
go test -race ./pkg/rewardspasses. Tests pin identical Go/Rust vectors, reject mutations to every bound field, reject role substitution, check oracle key equality, and enforce nonce encoding/length constraints.Containment remains in effect via #627 and its production-branch backport #629. Do not use this draft as authorization to restore signing or replenish affected pools.
Companion draft: OpenAudio/solana-programs#3