Symplify autowiring and remove backticks - #19
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19 +/- ##
============================================
+ Coverage 41.17% 45.08% +3.91%
- Complexity 52 65 +13
============================================
Files 12 13 +1
Lines 153 173 +20
============================================
+ Hits 63 78 +15
- Misses 90 95 +5 ☔ View full report in Codecov by Sentry. |
MKodde
left a comment
There was a problem hiding this comment.
A very nice effort to actually lever some useful newer Symfony constructions into the project. And a good call to stop using Doctrine ORM but opt for DBAL instead 🎩
I have some minor concerns listed below. Please have at them!
I am unsure if it was an error as the test results do not change after this fix. This is a smell of an untrusted test
e57b0da to
a350061
Compare
MKodde
left a comment
There was a problem hiding this comment.
One todo remains. I think adding the service tag is important to help existing users to upgrade with NOOP.
parijke
left a comment
There was a problem hiding this comment.
Reverted back to using tags
fixes #15
Advantages: really simple services.yml. If you want to override the autowiring defaults, you could define an entry in the services.yaml.
How it works:
All services which implements
HealthCheckInterfaceare tagged withopenconext.monitor.health_check, that is why is is not needed in the Extension anymore. The TaggableIterator is initialized with al services tagged like this. That is why the CompilerPass becomes obsolete.Just as flexible as before, just much simpeler. Thanks Symfony!
Also see: https://symfony.com/doc/current/bundles/extension.html