Restore the MediaTek no-video fix: 16 KB RX URBs via devourer + heap RX ring#107
Open
josephnef wants to merge 3 commits into
Open
Restore the MediaTek no-video fix: 16 KB RX URBs via devourer + heap RX ring#107josephnef wants to merge 3 commits into
josephnef wants to merge 3 commits into
Conversation
…RX ring Fixes the #6 regression reported on 2026-07-19. PR #104 bumped devourer past the transport split that deleted RtlUsbAdapter.cpp: the device-side half of floppyhammer's fix (16 KB RX aggregation caps) survived, but the host side regressed from 16 KB reads to 32 KB URBs — the exact transfer shape some MediaTek xhci/usbfs stacks (Dimensity 810, Helio G99, MT6765) never complete: LIBUSB_ERROR_TIMEOUT forever, zero RX, no video. - devourer submodule -> b7c50ec (OpenIPC/devourer#317, merged master): 16 KB URBs on all 11ac generations + matching Jaguar2/3 aggregation caps, tracked in OpenIPC/devourer#314. Bench-validated at delivery parity on RTL8812AU / RTL8812BU / RTL8812EU. - WfbngLink.cpp: cfg.usb.rx_zerocopy = false — keep the RX ring on plain heap buffers; the dev-mem zerocopy path is unvalidated on Android vendor kernels and every previously working Android build shipped the heap path. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
josephnef
force-pushed
the
restore-mtk-16k-fix
branch
from
July 20, 2026 11:05
de87388 to
3f3f25a
Compare
josephnef
marked this pull request as ready for review
July 20, 2026 11:06
josephnef
had a problem deploying
to
ANDROID_KEYSTORE
July 20, 2026 11:17 — with 
GitHub Actions
Failure
GitHub Actions
Failure
The APK build only compiles the devourer library source; devourer's reference/* submodules are vendor kernel drivers used solely by its extraction tooling and hardware tests, never by the build. Recursing into them clones eight extra repos on every build and — since devourer master now pins reference/rtl8852cu at a commit not present on its remote — fails the checkout outright. wfb-ng has no nested submodules, so submodules:true fetches exactly what the build needs (devourer + wfb-ng). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
josephnef
had a problem deploying
to
ANDROID_KEYSTORE
July 20, 2026 11:21 — with
GitHub Actions
Failure
GitHub Actions
Failure
PixelPilot vendors devourer's source list by hand (it can't add_subdirectory devourer — that resolves libusb via pkg-config, absent in the NDK build), so new devourer files must be mirrored here. The bump to b7c50ec pulled in two sources the compiled J1+J3 device classes now reference, causing link-time undefined symbols: - src/LaCapture.cpp (LaCapture::run / ctor — la_capture()) - src/jaguar3/PhydmRuntimeJaguar3.cpp (PhydmRuntimeJaguar3::tick) Both are self-contained (own headers + RtlAdapter, no excluded-group deps). Iqk8814a.cpp stays out — 8814 support isn't compiled here (no DEVOURER_HAVE_8814), so nothing references it. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the #6 regression reported 2026-07-19 (no video on MediaTek devices came back on master builds).
Root cause
#104 bumped the devourer submodule (
bbc7385→73f1cb4, ~3.5 months) past the transport split that deletedRtlUsbAdapter.cpp. @floppyhammer's fix (devourer #19, shipped here via #97) had two halves:Some MediaTek xhci/usbfs stacks (Dimensity 810, Helio G99, MT6765) never complete a bulk-IN read larger than 16 KB —
LIBUSB_ERROR_TIMEOUTforever, zero RX, no video. #104 was the first Android build of the async ring (its own description warned it was untested on hardware); the reports came straight back.Changes
b7c50ec(Jaguar USB RX: 16 KB URBs + matching agg caps — restore the MediaTek host fix devourer#317, tracked in Jaguar USB RX: 32 KB URBs regress MediaTek Android hosts (PixelPilot no-video) — restore the ≤16 KB read shape lost in the #213 transport split devourer#314): 16 KB URBs on all 11ac generations + matching Jaguar2/3 aggregation caps. Free on healthy hosts — with ≤16 KB aggregates a 32 KB URB never filled past 16 KB anyway.WfbngLink.cpp:cfg.usb.rx_zerocopy = false— keep the RX ring on plain heap buffers; the dev-mem zerocopy path is unvalidated on Android vendor kernels, and every previously working Android build shipped the heap path.Status
b7c50ec); submodule re-pinned to devourer master🤖 Generated with Claude Code