Fix ignored seed and sigma shift during sampling - #73
Open
primorLee wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The public MOVA inference API accepts both
seedandsigma_shift, and the official inference scripts expose them, but neither value currently reaches sampling:prepare_latentsandprepare_audio_latentsare called withgenerator=None, soseeddoes not control the pipeline RNG.scheduler.set_timestepsis called withoutshift=sigma_shift, so non-default sigma shifts are ignored.This change creates one CPU generator from
seedand passes it through the video and audio noise initializers, then forwardssigma_shiftto the scheduler. Reusing one generator keeps the complete joint video-audio sample deterministic, whileseed=Nonepreserves global-RNG behavior.The default output schedule is unchanged for the released checkpoints because their scheduler configuration and the public argument both default to shift 5.
Validation
sigma_shift=4.25is forwarded toset_timestepstogether with the requested step count and execution device.git diff --check.