Skip to content

Fix an incorrect static count being returned - #859

Merged
Kyle-Ye merged 1 commit into
OpenSwiftUIProject:mainfrom
jcmosc:fix-incorrect-static-count
May 14, 2026
Merged

Fix an incorrect static count being returned#859
Kyle-Ye merged 1 commit into
OpenSwiftUIProject:mainfrom
jcmosc:fix-incorrect-static-count

Conversation

@jcmosc

@jcmosc jcmosc commented May 14, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@jcmosc
jcmosc requested a review from Kyle-Ye as a code owner May 14, 2026 15:02
@augmentcode

augmentcode Bot commented May 14, 2026

Copy link
Copy Markdown
🤖 Augment PR Summary

Summary: Fixes aggregation of _ViewListOutputs.staticCount so the merged static count becomes nil as soon as any output lacks a static count.

Change: Updates the fold logic to only accumulate when the prior merged value is non-nil, preventing later non-nil entries from incorrectly “reviving” a static count.

🤖 Was this summary useful? React with 👍 or 👎

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

@Kyle-Ye Kyle-Ye left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Once a staticCount is nil, the mergedStaticCount should be nil instead of re-compute from zero

@Kyle-Ye
Kyle-Ye merged commit 39e3855 into OpenSwiftUIProject:main May 14, 2026
6 of 10 checks passed
@Kyle-Ye Kyle-Ye added the type: bug Something is not working correctly. label May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug Something is not working correctly.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants