Skip to content

Fix Example Debug compilation conditions - #883

Merged
Kyle-Ye merged 1 commit into
mainfrom
codex/fix-example-debug-conditions
May 28, 2026
Merged

Fix Example Debug compilation conditions#883
Kyle-Ye merged 1 commit into
mainfrom
codex/fix-example-debug-conditions

Conversation

@Kyle-Ye

@Kyle-Ye Kyle-Ye commented May 28, 2026

Copy link
Copy Markdown
Member

Agent Summary

This updates the Example Tuist package settings so generated package targets receive DEBUG in Debug configurations, matching the app targets and allowing debug-only code paths to compile into the Example build.

The change also makes ViewRendererVendor print as its raw vendor identifier, supports string literal initialization for the wrapper type, and prefixes the renderer diagnostic as OpenSwiftUI ViewRendererVendor: ... for easier console scanning.

Root cause: the Example app targets had Debug compilation conditions, but the Tuist-generated package targets such as OpenSwiftUICore used separate package settings that only configured optimization and compilation mode.

Validation:

  • mise exec -- tuist generate --no-open
  • xcodebuild -workspace Example/Example.xcworkspace -scheme OSUI_Example -configuration OpenSwiftUIDebug -sdk iphonesimulator -destination 'generic/platform=iOS Simulator' CODE_SIGNING_ALLOWED=NO build
  • swift build --target OpenSwiftUICore

@github-actions github-actions Bot added area: example Example apps, previews, sample projects, screenshots, or demo assets. area: rendering DisplayList, render backends, renderer hosts, drawing, and effects. area: tooling Developer tooling, package manifests, Tuist, scripts, formatting, or release tooling. type: bug Something is not working correctly. labels May 28, 2026
@Kyle-Ye Kyle-Ye changed the title [codex] Fix Example Debug compilation conditions Fix Example Debug compilation conditions May 28, 2026
@Kyle-Ye
Kyle-Ye marked this pull request as ready for review May 28, 2026 18:38
@augmentcode

augmentcode Bot commented May 28, 2026

Copy link
Copy Markdown
🤖 Augment PR Summary

Summary: Aligns the Example Tuist-generated package target settings with the app targets so Debug builds define DEBUG and debug-only code paths compile.
Changes: Adds Debug compilation conditions to package settings, improves ViewRendererVendor stringification (raw value + string-literal init), and prefixes the debug renderer diagnostic for easier log scanning.

🤖 Was this summary useful? React with 👍 or 👎

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

@codecov

codecov Bot commented May 28, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 13.78%. Comparing base (aa8f2c0) to head (dcafea8).

Files with missing lines Patch % Lines
...e/Render/DisplayList/DisplayListViewRenderer.swift 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (aa8f2c0) and HEAD (dcafea8). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (aa8f2c0) HEAD (dcafea8)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #883       +/-   ##
===========================================
- Coverage   26.95%   13.78%   -13.17%     
===========================================
  Files         678      638       -40     
  Lines       47144    41344     -5800     
===========================================
- Hits        12706     5701     -7005     
- Misses      34438    35643     +1205     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kyle-Ye
Kyle-Ye merged commit 5bba281 into main May 28, 2026
3 of 7 checks passed
@Kyle-Ye
Kyle-Ye deleted the codex/fix-example-debug-conditions branch May 28, 2026 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: example Example apps, previews, sample projects, screenshots, or demo assets. area: rendering DisplayList, render backends, renderer hosts, drawing, and effects. area: tooling Developer tooling, package manifests, Tuist, scripts, formatting, or release tooling. type: bug Something is not working correctly.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant