Add environment-configurable formatter support - #884
Merged
Conversation
Kyle-Ye
marked this pull request as ready for review
May 30, 2026 10:35
🤖 Augment PR SummarySummary: Adds a small internal protocol to make Foundation formatters apply text-related Changes:
Technical Notes: The configuration focuses on properties that directly affect formatted text output (locale/calendar/time zone) and keeps platform availability differences behind conditional compilation. 🤖 Was this summary useful? React with 👍 or 👎 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #884 +/- ##
===========================================
+ Coverage 13.79% 26.92% +13.12%
===========================================
Files 639 679 +40
Lines 41360 47281 +5921
===========================================
+ Hits 5706 12730 +7024
+ Misses 35654 34551 -1103 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EnvironmentConfigurableFormatterfor applyingEnvironmentValuesto Foundation formatters used by text formatting.Testing
swift buildswift build --target OpenSwiftUICoreTestsswift test --scratch-path .build-env-formatter-test --disable-experimental-prebuilts --filter 'OpenSwiftUICoreTests.EnvironmentConfigurableFormatterTests'\n- Linuxswift build --build-path .build-linuxwithOPENSWIFTUI_LIB_SWIFT_PATH